Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding the ability to replace template parts in template part focus mode #39864

Closed
annezazu opened this issue Mar 29, 2022 · 3 comments
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This came up as part of the twelfth FSE Outreach Program call for testing:

Specifically, I really LOVE the new “Replace” button to choose between an existing template or a Pattern. But I wish I could “Replace” with a Pattern even in focus mode. If I came to this screen to really work on my header, why would I have less options here than I have when looking at the full site?

Here's a quick visual showing how you can replace when in the Site Editor but that option goes away when in focus mode:

replace.option.mov

What is your proposed solution?

I know previously work was done to limit the overall template part settings displayed in focus mode to reduce confusion (#30732, #36571) but I wonder if there's a way to bring just the option to Replace the template part will work nicely without opening the can of worms of further customization.

This feels related to this work of showing patterns as section too, specifically around offering more ways to cycle through patterns: #39281 cc @jameskoster

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts labels Mar 29, 2022
@jameskoster
Copy link
Contributor

This is good feedback, thanks for the mention!

I think we need to tread a little carefully so that we don't conflate the purpose of each view/mode. The regular editor view is optimised for editing the blocks within a template, so it is reasonable that you're able to entirely replace things like headers and footers with relative ease.

If I came to this screen to really work on my header

This is the key point I think. The purpose of focus mode (imo) is to concentrate on the blocks within complex units like headers. It's more about fine-tuning than entirely replacing. There is certainly work to be done to refine those heuristics, and I think you're right that 39281 will help a lot there.

All that said, there are probably certain conditions in which focus mode could prioritise surfacing patterns. For example if you create a new header from scratch, or delete all the blocks within the header you're editing.

@github-actions
Copy link

Hi,
This issue has gone 180 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the Needs Testing Needs further testing to be confirmed. label Sep 27, 2022
@annezazu annezazu removed the Needs Testing Needs further testing to be confirmed. label Sep 28, 2022
@annezazu
Copy link
Contributor Author

annezazu commented Oct 3, 2022

Going to close this out in favor of this new issue that would address this (and has a clear design): #44582

@annezazu annezazu closed this as completed Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Focus Mode Zoomed in focus mode for editing things like template parts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants