Query Block: ensure focus is on Query Block after insertion

[annezazu]

What problem does this address?

This came up during the fifth call for testing for the FSE Outreach Program:

I tried inserting one of the block’s patterns called Large title and upon insertion, the editor focused the Group block and not the Query block. This was very disconcerting. I inserted a Query Block so I didn’t expect to see a Group block. I guess the group is used to wrap the pattern but we need to make sure we’re focusing on the block the user chose to insert and not the wrapper of the pattern

Screen.Capture.on.2021-04-22.at.08-54-51.mp4

What is your proposed solution?

Ensure the focus is put on the Query Block rather than the Group Block as it immediately adds a hurtle to customizing the Query Block. Of note, @kjellr this seems to mainly be related to the new patterns added in with this PR as it does not happen with 10.4.1 but does when I use this PR: #30763

[ntsekouras]

Hey 👋 - this is not related to Query specifically but to the Pattern suggesting in placeholder functionality.

This new functionality allows the usage of more complex patterns that don't necessarily include only the blocks from which are shown. While there could be a way to fine tune this for Query, it would also create confusion when patterns contain more than one Query blocks like the Offset bundled pattern in GB.

[annezazu]

Thanks for the wider context! I wonder what the best solution is here or if this is a "won't fix".

[kjellr]

Yeah, I'm not sure. I bet we could technically shift focus to the first Query block in the pattern when it's inserted? Might be worth a PR to see if it feels natural.

[ntsekouras]

I'm not sure either, although I lean to a won't fix a bit more :). On the other hand most Query patterns will probably include one Query block so it doesn't hurt to make a PR for exploring this.