-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When editing the page_for_posts page the canvas should match the front end #29821
Comments
I don't know that this necessarily needs design. Essentially if I open the page assigned to |
This issue is especially pertinent now that it is possible to directly move from editing a page to editing a template: posts.page.mp4Edit: Re-adding the needs design label. This needs some consideration to account for both classic and block themes. |
It's actually possible to "break" the functionality currently by assigning the "wrong" template. Using a general page template would result in the posts page no longer displaying posts. Initial thought: Since the template for this page resolves automatically, It should not be possible to change the template in the UI. Creating a new template should be possible once – this action spawns the Edit: After a chat with @youknowriad, it probably makes most sense to simply hide the template panel for this page for 5.8. This mimics how the classic editor treats this page. |
Here's an experiment that allows editing the Posts page template (and any other page template) when editing a page: #32022 |
It would be nice to revisit this now that the site editor is live. One option might be to redirect folks to the Site Editor and open the Another option would be to open the template editor that exists in the post editor. |
Yup, that is another option. But it's tricky for a few reasons:
All of this might result in too much of a detachment from the expected page editing experience. |
@aurooba made this associated issue: Also sharing the Core Editor Slack conversation that is also happening: |
I'm going to go ahead and close #38389 and add my thoughts here because it makes a bit more sense to keep it all in an issue: This is a confusion I encountered myself – despite understanding the WordPress Template Hierarchy extremely well – and have watched others encounter too. It stems from being able to do things one way before and having the paradigm change in FSE. When you set a When a Here's what I'm thinkingWhen a |
I think redirecting to the site editor makes sense. Maybe the code from #36294 could be re-purposed for this. |
This doesn't seem like a regression, so punting |
I'd appreciate more testing, but this may be fixed now.
Note that the correct template is referenced in the Inspector, compared with the screenshots above. Tentatively closing, but let's re-open if there reports to the contrary. |
Setting a static home page unlocks an affordance to specify a separate page to display the post archive:
When presented in the editor the content of this page does not reflect what you see on the frontend. Indeed any changes you make are essentially ignored until you unset this page as the
page_for_posts
.Here's an example of a perfectly reasonable user flow which behaves in a very unexpected way:
confusion.mp4
I appreciate this isn't really a bug – WordPress has always handled this the same way. But with all the blocks we've built for the Site Editor there's potential for us to do better in this specific instance. To kick off discussion, one idea would be for this page to display a single Query block, which cannot be removed. Perhaps some of the attributes are locked as well. Pattern transforms (#28736) could be possible.
It's worth acknowledging that this issue is not restricted to the page for posts. There are other templates in the site editor that should 'lock down' specific blocks. I think that is a slightly different issue though, and worth discussing elsewhere (#27848 (comment)).
Edit: This is somewhat related to #28341
The text was updated successfully, but these errors were encountered: