Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Actions: Make page name and page slug editable in the site editor topbar #25586

Closed
jeyip opened this issue Sep 23, 2020 · 10 comments
Closed
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.

Comments

@jeyip
Copy link
Contributor

jeyip commented Sep 23, 2020

Description

As a user, I want to edit the page title and slug in the site editor (which currently isn't possible)

Potential Mocks

THESE ARE NOT FINALIZED DESIGNS

post-edit-document-menu

Related Issues:

#25546

@jeyip
Copy link
Contributor Author

jeyip commented Sep 23, 2020

Currently on hold and awaiting further discussion @dubielzyk @shaunandrews

@paaljoachim
Copy link
Contributor

I believe the most important part right now is just moving the page/post title up into the top bar, and have a drop down with the permalink available. That seems to be the MVP at present time. At the same time we also need a page/post title block.

Getting this in a soon as possible would help us see how it functions with having the page/post title in the middle of the top bar. As one would be able to gain a lot of feedback from this.

@noahtallen
Copy link
Member

@paaljoachim yep, we're working on the page/post title bits of this right now. We're waiting a few days for some more design iterations on the dropdown aspect of things, since the early design prototypes generated a lot of feedback and discussion. Jeremy has a PR open (#25386) which starts exploring the dropdown approach if you want to check it out

@shaunandrews
Copy link
Contributor

I posted design updates GIFs over in #20877 (comment)

document-details

@dubielzyk
Copy link

If the label isn't clickable, I don't see why we wouldn't make the whole thing a button to increase click area. Like where this is heading

@noahtallen
Copy link
Member

I don't see why we wouldn't make the whole thing a button to increase click area

It addresses the accessibility feedback that if the text is going to be a button, it should describe the action the button will do. (this comment explains why).

Though I do totally agree that the text being a button would be very helpful for one set of users, it seems that it would be a hindrance for another.

@jeyip
Copy link
Contributor Author

jeyip commented Sep 28, 2020

We will not be making page name and page slug editable in the site editor for now. We can return to this whenever "template editing" is better developed.

@jeyip jeyip closed this as completed Sep 28, 2020
@noahtallen
Copy link
Member

I vote to leave the issue open for now, just on hold :)

@jeyip jeyip reopened this Sep 28, 2020
@paaljoachim
Copy link
Contributor

paaljoachim commented Oct 6, 2020

(From my understanding...)
This looks like a good way forward.
I do feel there is agreement of adding the permalink and the title to the drop down.
I would suggest going with @shaunandrews suggestion but leaving out the template part. That can be added in the next iteration.

@noahtallen noahtallen removed their assignment Dec 9, 2020
@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@youknowriad
Copy link
Contributor

The action bar has been redesigned entirely in 6.3 making this issue irrelevant IMO. If we want further iterations on the action bar, we should open new issues I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Accessibility Feedback Need input from accessibility [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

9 participants