-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Block: Post Date #19697
Comments
I think it's cleaner to keep it together with the format.
Yes, I think this should be in the toolbar and that the calendar should open when clicking on the date in the block itself. This aligns better with the philosophy of direct manipulation. |
Look at me just defaulting to the sidebar! Thanks for pulling me back, @epiqueras. Here's are some revised mockups. Date selectionDate and time formatNotes
|
That looks so much better! Nice work.
Yeah, we can drop it.
I would like to see something more descriptive here. Maybe a sketch of 2 different formats with a slash between them? |
How about a calendar with a clock and some sort of edit indicator?
|
I like the first one the most.
|
The calendar is less clear on the second one and the third one blurs the
pencil.
|
It should default to that. |
Localization can break the layout with long words. |
What's the solution for the Image block then, in regards to i18n with "Replace"? |
There isn't one. We could make an icon with a thumbnail and a replacement arrow. |
I noticed this issues has a lot of chatter around editing the date itself. This brings up an interesting question; Are you editing the post itself? If so this will bring up some interesting complexities around saving and publishing changes. Instead, I'd suggest that this Block (and the other related Post blocks) are more about display content defined elsewhere. Options on these blocks should allow users to adjust display properties (color, font, size, date format, alignment, etc) but the content itself should not be editable. In the context of the larger Post block, the Once the post is selected, the option could be accessible from the sidebar: -- I'm a fan of using a labelled dropdown for the formatting options. Something like this is what I would expect: Combining the day and time formatting would also mean we wouldn't need the "Show time" switch in the sidebar. |
I think that argument can be made for things like the date because of scheduling. But directly manipulating the excerpt is a lot more intuitive. The same can be said of the featured image, for example.
Replicating this functionality in every post field is repetitive. You would wrap it in a post block that already has a post selector.
Yes, we are already doing that. |
Hmmm, I don't know. Unless the contents of the excerpt is isolated (and not actually editing the excerpt data for the post in the DB), I could see there being confusion around editing a post's data and not understanding that it will change it everywhere. Also, there'd still be an issue around saving post data — would the data be saved immediately? When you published the post/page that contains the customized block? What if the page containing this block is scheduled, would we only update the post data when the page is published?
But what if these post-related blocks are used outside of a post block? Or, is that not something we'd want, or would consider useful? |
This is all related to global change saving. See the discussions on #18029.
They will inherit the root post ID if any, otherwise they will show a placeholder. This approach optimizes for being able to easily move these blocks between post and query blocks and reuse layout pieces across different contexts without having to deal with post-selection at multiple levels. |
As indicated in #15623, there will be a suite of Post blocks that make up the Post template.
This is the Post Date block.
Features
Mockups
Questions
The text was updated successfully, but these errors were encountered: