Skip to content

Commit f430cd7

Browse files
Fix: Dataviews remove primary field concept from some classes. (#67689)
Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: youknowriad <[email protected]>
1 parent 95cbcdf commit f430cd7

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

packages/dataviews/src/dataviews-layouts/grid/index.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,11 @@ function GridItem< Item >( {
8282
className: 'dataviews-view-grid__media',
8383
} );
8484

85-
const clickablePrimaryItemProps = getClickableItemProps( {
85+
const clickableTitleItemProps = getClickableItemProps( {
8686
item,
8787
isItemClickable,
8888
onClickItem,
89-
className: 'dataviews-view-grid__primary-field dataviews-title-field',
89+
className: 'dataviews-view-grid__title-field dataviews-title-field',
9090
} );
9191

9292
return (
@@ -128,9 +128,7 @@ function GridItem< Item >( {
128128
justify="space-between"
129129
className="dataviews-view-grid__title-actions"
130130
>
131-
<div { ...clickablePrimaryItemProps }>
132-
{ renderedTitleField }
133-
</div>
131+
<div { ...clickableTitleItemProps }>{ renderedTitleField }</div>
134132
<ItemActions item={ item } actions={ actions } isCompact />
135133
</HStack>
136134
<VStack spacing={ 1 }>

packages/dataviews/src/dataviews-layouts/grid/style.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
padding: $grid-unit-10 0 $grid-unit-05;
1616
}
1717

18-
.dataviews-view-grid__primary-field {
18+
.dataviews-view-grid__title-field {
1919
min-height: $grid-unit-30; // Preserve layout when there is no ellipsis button
2020
display: flex;
2121
align-items: center;

packages/dataviews/src/dataviews-layouts/list/style.scss

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ ul.dataviews-view-list {
5050
}
5151

5252
&:not(.is-selected) {
53-
.dataviews-view-list__primary-field {
53+
.dataviews-view-list__title-field {
5454
color: $gray-900;
5555
}
5656
&:hover,
@@ -59,7 +59,7 @@ ul.dataviews-view-list {
5959
color: var(--wp-admin-theme-color);
6060
background-color: #f8f8f8;
6161

62-
.dataviews-view-list__primary-field,
62+
.dataviews-view-list__title-field,
6363
.dataviews-view-list__fields {
6464
color: var(--wp-admin-theme-color);
6565
}
@@ -74,7 +74,7 @@ ul.dataviews-view-list {
7474
background-color: rgba(var(--wp-admin-theme-color--rgb), 0.04);
7575
color: $gray-900;
7676

77-
.dataviews-view-list__primary-field,
77+
.dataviews-view-list__title-field,
7878
.dataviews-view-list__fields {
7979
color: var(--wp-admin-theme-color);
8080
}
@@ -106,7 +106,7 @@ ul.dataviews-view-list {
106106
}
107107
}
108108
}
109-
.dataviews-view-list__primary-field {
109+
.dataviews-view-list__title-field {
110110
flex: 1;
111111
min-height: $grid-unit-30;
112112
line-height: $grid-unit-30;

0 commit comments

Comments
 (0)