Skip to content

Commit 45cd61a

Browse files
committed
Make spreads a bit more readable and make sure customCSS added to default also
1 parent 0a4294b commit 45cd61a

File tree

1 file changed

+18
-15
lines changed

1 file changed

+18
-15
lines changed

packages/edit-site/src/components/global-styles/style-variations-container.js

Lines changed: 18 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,14 @@ export default function StyleVariationsContainer( { gap = 2 } ) {
3636
);
3737
} );
3838

39+
multiplePropertyVariations.unshift( {
40+
title: __( 'Default' ),
41+
settings: {},
42+
styles: {},
43+
} );
44+
3945
const withEmptyVariation = useMemo( () => {
4046
return [
41-
{
42-
title: __( 'Default' ),
43-
settings: {},
44-
styles: {},
45-
},
4647
...( multiplePropertyVariations ?? [] ).map( ( variation ) => {
4748
const blockStyles = { ...variation?.styles?.blocks } || {};
4849
// We need to copy any user custom CSS to the variation to prevent it being lost
@@ -52,10 +53,11 @@ export default function StyleVariationsContainer( { gap = 2 } ) {
5253
// First get any block specific custom CSS from the current user styles and merge with any custom CSS for
5354
// that block in the variation.
5455
if ( userStyles.blocks[ blockName ].css ) {
56+
const variationBlockStyles =
57+
blockStyles[ blockName ] || {};
58+
5559
blockStyles[ blockName ] = {
56-
...( blockStyles[ blockName ]
57-
? blockStyles[ blockName ]
58-
: {} ),
60+
...variationBlockStyles,
5961
css: `${
6062
blockStyles[ blockName ]?.css || ''
6163
} ${ userStyles.blocks[ blockName ].css }`,
@@ -64,15 +66,16 @@ export default function StyleVariationsContainer( { gap = 2 } ) {
6466
} );
6567
}
6668
// Now merge any global custom CSS from current user styles with global custom CSS in the variation.
69+
const globalCustomCSS =
70+
userStyles?.css || variation.styles?.css
71+
? `${ variation.styles?.css || '' } ${
72+
userStyles?.css || ''
73+
}`
74+
: '';
75+
6776
const styles = {
6877
...variation.styles,
69-
...( userStyles?.css || variation.styles?.css
70-
? {
71-
css: `${ variation.styles?.css || '' } ${
72-
userStyles?.css
73-
}`,
74-
}
75-
: {} ),
78+
css: globalCustomCSS,
7679
blocks: {
7780
...blockStyles,
7881
},

0 commit comments

Comments
 (0)