From 1e7b6660961fc37de7bb2fd8d1dab0e364ec4dbe Mon Sep 17 00:00:00 2001 From: Kai Hao Date: Thu, 18 Apr 2024 10:18:44 +0800 Subject: [PATCH] Fix allow overrides check --- .../src/components/pattern-overrides-controls.js | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/packages/patterns/src/components/pattern-overrides-controls.js b/packages/patterns/src/components/pattern-overrides-controls.js index fdb5e813a1c856..f90dae83673ed9 100644 --- a/packages/patterns/src/components/pattern-overrides-controls.js +++ b/packages/patterns/src/components/pattern-overrides-controls.js @@ -38,9 +38,10 @@ function PatternOverridesControls( { attributes, setAttributes } ) { const [ showDisallowOverridesModal, setShowDisallowOverridesModal ] = useState( false ); + const hasName = !! attributes.metadata?.name; const defaultBindings = attributes.metadata?.bindings?.__default; const allowOverrides = - defaultBindings?.source === PATTERN_OVERRIDES_BINDING_SOURCE; + hasName && defaultBindings?.source === PATTERN_OVERRIDES_BINDING_SOURCE; const isConnectedToOtherSources = defaultBindings?.source && defaultBindings.source !== PATTERN_OVERRIDES_BINDING_SOURCE; @@ -67,14 +68,6 @@ function PatternOverridesControls( { attributes, setAttributes } ) { // Avoid overwriting other (e.g. meta) bindings. if ( isConnectedToOtherSources ) return null; - - const hasName = !! attributes.metadata?.name; - const allowOverrides = - hasName && - attributeSources.some( - ( source ) => source === PATTERN_OVERRIDES_BINDING_SOURCE - ); - return ( <>