Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback - How to create an animated timeline plugin #310

Closed
iambherulal opened this issue Sep 12, 2024 · 3 comments
Closed

Feedback - How to create an animated timeline plugin #310

iambherulal opened this issue Sep 12, 2024 · 3 comments
Assignees
Labels
Content Feedback Errors or other Feedback

Comments

@iambherulal
Copy link

Description

I was following a tutorial and noticed an issue with the filename. It's not a typo, but rather a character issue. In the tutorial, a double dash in the filename is mistakenly shown as a single dash, while the code snippet still uses the double dash. When someone copies and pastes the filename, it causes a mismatch.

Step-by-step reproduction instructions (optional)

Please list the steps needed to reproduce or verify the feedback. For example:

  1. Go to - https://developer.wordpress.org/news/2024/06/13/how-to-create-an-animated-timeline-plugin/#animated-timeline-plugin-setup

  2. In this section you can see the CSS and js files with the full path name, In the filename after the group there should a double dash.

    •   /assets/scripts/core-blocks/group–animated-timeline.js -> assets/scripts/core-blocks/group--animated-timeline.js
      
    •   /assets/styles/core-blocks/group–animated-timeline.css -> /assets/styles/core-blocks/group--animated-timeline.css
      
  3. As you can see in the snippet - https://developer.wordpress.org/news/2024/06/13/how-to-create-an-animated-timeline-plugin/#register-custom-css-and-javascript-files

@bph
Copy link
Collaborator

bph commented Sep 12, 2024

Thank you, @iambherulal iambherulal, for spotting this and spending the time filing a 'bug' report. @colorful-tones could double-check this, please?

@bph bph assigned bph and colorful-tones and unassigned bph Sep 12, 2024
@bph bph added the Content Feedback Errors or other Feedback label Sep 12, 2024
@colorful-tones
Copy link
Member

@iambherulal - I really appreciate you taking the time to report that critical item. I've updated the affected section in the post to fix the --. Enjoy your weekend!

@iambherulal
Copy link
Author

Thank you @colorful-tones @bph

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Feedback Errors or other Feedback
Projects
None yet
Development

No branches or pull requests

3 participants