Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to custom block style variations are lost #699

Open
onetrev opened this issue Aug 13, 2024 · 0 comments
Open

Edits to custom block style variations are lost #699

onetrev opened this issue Aug 13, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@onetrev
Copy link

onetrev commented Aug 13, 2024

I believe the problem is Create Block Theme is trying to write the styles to your theme.json file and it's not supported yet, so what happens in nothing gets written, but Create Block Theme clears all db edits expecting the edits were saved to your theme.json file.

NOTE! If you are the Gutenberg plugin active, then it does work and your custom style variations are saved to theme.json.

  1. Use Twenty Twenty Four theme and WP 6.6.1.

  2. Created a Block Style Variation, whether created by JS, PHP, or Section Style, the same issue occurs. I used Section Style for this demo, since it's the fastest, so let's stick with that for recreating it.

  3. Here's the current style it set in my section style for a new custom block style for a button called "Fancy Button". It has black bg, white text.

Initial styles

  1. Now using the Site Editor "Styles" editor, make some changes. I made the bg orange.
    Change style of custom style variation

  2. Save changes with Create Block Theme, ensuring "Save Style Changes" is selected.
    Create Block Theme Save Styles

  3. Boom! All your styles are gone, the original block variation styles are back as they are not saved to your theme.json and the database changes are removed (the latter is supposed to happen since that's what Create Block Theme is meant to do).

Styles Gone

I've have also noted this issue in the Gutenberg repo, and have been working on it with @aaronrobertshaw.

@t-hamano t-hamano added the bug Something isn't working label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants