From ef36c115feedeccc3047914ce6d40e3e2fd6bfb0 Mon Sep 17 00:00:00 2001 From: Vicente Canales Date: Tue, 24 Oct 2023 21:33:09 +0200 Subject: [PATCH] Replace null with empty string on add menu page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Achieves the same effect — keeping those submenus from being displayed — while avoiding PHP errors. Closes: https://github.com/WordPress/create-block-theme/issues/168 --- admin/class-manage-fonts.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/class-manage-fonts.php b/admin/class-manage-fonts.php index 4a318d15..d128ad0f 100644 --- a/admin/class-manage-fonts.php +++ b/admin/class-manage-fonts.php @@ -38,11 +38,11 @@ function create_admin_menu() { $google_fonts_page_title = _x( 'Embed Google font in the active theme', 'UI String', 'create-block-theme' ); $google_fonts_menu_title = $google_fonts_page_title; - add_submenu_page( null, $google_fonts_page_title, $google_fonts_menu_title, 'edit_theme_options', 'add-google-font-to-theme-json', array( 'Google_Fonts', 'google_fonts_admin_page' ) ); + add_submenu_page( '', $google_fonts_page_title, $google_fonts_menu_title, 'edit_theme_options', 'add-google-font-to-theme-json', array( 'Google_Fonts', 'google_fonts_admin_page' ) ); $local_fonts_page_title = _x( 'Embed local font in the active theme', 'UI String', 'create-block-theme' ); $local_fonts_menu_title = $local_fonts_page_title; - add_submenu_page( null, $local_fonts_page_title, $local_fonts_menu_title, 'edit_theme_options', 'add-local-font-to-theme-json', array( 'Local_Fonts', 'local_fonts_admin_page' ) ); + add_submenu_page( '', $local_fonts_page_title, $local_fonts_menu_title, 'edit_theme_options', 'add-local-font-to-theme-json', array( 'Local_Fonts', 'local_fonts_admin_page' ) ); } function has_file_and_user_permissions() {