Use new HttpStatus utility class in exceptions and TransportMock

schlessera · schlessera · commit 617a5dfa44cc · 2023-10-10T21:17:36.000+02:00
diff --git a/src/Exception/Http/Status304.php b/src/Exception/Http/Status304.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 304 Not Modified responses
@@ -27,5 +28,5 @@ final class Status304 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Not Modified';
+	protected $reason = HttpStatus::TEXT_304;
 }
diff --git a/src/Exception/Http/Status305.php b/src/Exception/Http/Status305.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 305 Use Proxy responses
@@ -27,5 +28,5 @@ final class Status305 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Use Proxy';
+	protected $reason = HttpStatus::TEXT_305;
 }
diff --git a/src/Exception/Http/Status306.php b/src/Exception/Http/Status306.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 306 Switch Proxy responses
@@ -27,5 +28,5 @@ final class Status306 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Switch Proxy';
+	protected $reason = HttpStatus::TEXT_306;
 }
diff --git a/src/Exception/Http/Status400.php b/src/Exception/Http/Status400.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 400 Bad Request responses
@@ -27,5 +28,5 @@ final class Status400 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Bad Request';
+	protected $reason = HttpStatus::TEXT_400;
 }
diff --git a/src/Exception/Http/Status401.php b/src/Exception/Http/Status401.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 401 Unauthorized responses
@@ -27,5 +28,5 @@ final class Status401 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Unauthorized';
+	protected $reason = HttpStatus::TEXT_401;
 }
diff --git a/src/Exception/Http/Status402.php b/src/Exception/Http/Status402.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 402 Payment Required responses
@@ -27,5 +28,5 @@ final class Status402 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Payment Required';
+	protected $reason = HttpStatus::TEXT_402;
 }
diff --git a/src/Exception/Http/Status403.php b/src/Exception/Http/Status403.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 403 Forbidden responses
@@ -27,5 +28,5 @@ final class Status403 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Forbidden';
+	protected $reason = HttpStatus::TEXT_403;
 }
diff --git a/src/Exception/Http/Status404.php b/src/Exception/Http/Status404.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 404 Not Found responses
@@ -27,5 +28,5 @@ final class Status404 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Not Found';
+	protected $reason = HttpStatus::TEXT_404;
 }
diff --git a/src/Exception/Http/Status405.php b/src/Exception/Http/Status405.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 405 Method Not Allowed responses
@@ -27,5 +28,5 @@ final class Status405 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Method Not Allowed';
+	protected $reason = HttpStatus::TEXT_405;
 }
diff --git a/src/Exception/Http/Status406.php b/src/Exception/Http/Status406.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 406 Not Acceptable responses
@@ -27,5 +28,5 @@ final class Status406 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Not Acceptable';
+	protected $reason = HttpStatus::TEXT_406;
 }
diff --git a/src/Exception/Http/Status407.php b/src/Exception/Http/Status407.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 407 Proxy Authentication Required responses
@@ -27,5 +28,5 @@ final class Status407 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Proxy Authentication Required';
+	protected $reason = HttpStatus::TEXT_407;
 }
diff --git a/src/Exception/Http/Status408.php b/src/Exception/Http/Status408.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 408 Request Timeout responses
@@ -27,5 +28,5 @@ final class Status408 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Request Timeout';
+	protected $reason = HttpStatus::TEXT_408;
 }
diff --git a/src/Exception/Http/Status409.php b/src/Exception/Http/Status409.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 409 Conflict responses
@@ -27,5 +28,5 @@ final class Status409 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Conflict';
+	protected $reason = HttpStatus::TEXT_409;
 }
diff --git a/src/Exception/Http/Status410.php b/src/Exception/Http/Status410.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 410 Gone responses
@@ -27,5 +28,5 @@ final class Status410 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Gone';
+	protected $reason = HttpStatus::TEXT_410;
 }
diff --git a/src/Exception/Http/Status411.php b/src/Exception/Http/Status411.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 411 Length Required responses
@@ -27,5 +28,5 @@ final class Status411 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Length Required';
+	protected $reason = HttpStatus::TEXT_411;
 }
diff --git a/src/Exception/Http/Status412.php b/src/Exception/Http/Status412.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 412 Precondition Failed responses
@@ -27,5 +28,5 @@ final class Status412 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Precondition Failed';
+	protected $reason = HttpStatus::TEXT_412;
 }
diff --git a/src/Exception/Http/Status413.php b/src/Exception/Http/Status413.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 413 Request Entity Too Large responses
@@ -27,5 +28,5 @@ final class Status413 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Request Entity Too Large';
+	protected $reason = HttpStatus::TEXT_413;
 }
diff --git a/src/Exception/Http/Status414.php b/src/Exception/Http/Status414.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 414 Request-URI Too Large responses
@@ -27,5 +28,5 @@ final class Status414 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Request-URI Too Large';
+	protected $reason = HttpStatus::TEXT_414;
 }
diff --git a/src/Exception/Http/Status415.php b/src/Exception/Http/Status415.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 415 Unsupported Media Type responses
@@ -27,5 +28,5 @@ final class Status415 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Unsupported Media Type';
+	protected $reason = HttpStatus::TEXT_415;
 }
diff --git a/src/Exception/Http/Status416.php b/src/Exception/Http/Status416.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 416 Requested Range Not Satisfiable responses
@@ -27,5 +28,5 @@ final class Status416 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Requested Range Not Satisfiable';
+	protected $reason = HttpStatus::TEXT_416;
 }
diff --git a/src/Exception/Http/Status417.php b/src/Exception/Http/Status417.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 417 Expectation Failed responses
@@ -27,5 +28,5 @@ final class Status417 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Expectation Failed';
+	protected $reason = HttpStatus::TEXT_417;
 }
diff --git a/src/Exception/Http/Status418.php b/src/Exception/Http/Status418.php
@@ -10,6 +10,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 418 I'm A Teapot responses
@@ -31,5 +32,5 @@ final class Status418 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = "I'm A Teapot";
+	protected $reason = HttpStatus::TEXT_418;
 }
diff --git a/src/Exception/Http/Status428.php b/src/Exception/Http/Status428.php
@@ -10,6 +10,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 428 Precondition Required responses
@@ -31,5 +32,5 @@ final class Status428 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Precondition Required';
+	protected $reason = HttpStatus::TEXT_428;
 }
diff --git a/src/Exception/Http/Status429.php b/src/Exception/Http/Status429.php
@@ -10,6 +10,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 429 Too Many Requests responses
@@ -31,5 +32,5 @@ final class Status429 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Too Many Requests';
+	protected $reason = HttpStatus::TEXT_429;
 }
diff --git a/src/Exception/Http/Status431.php b/src/Exception/Http/Status431.php
@@ -10,6 +10,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 431 Request Header Fields Too Large responses
@@ -31,5 +32,5 @@ final class Status431 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Request Header Fields Too Large';
+	protected $reason = HttpStatus::TEXT_431;
 }
diff --git a/src/Exception/Http/Status500.php b/src/Exception/Http/Status500.php
@@ -8,6 +8,7 @@
 namespace WpOrg\Requests\Exception\Http;
 
 use WpOrg\Requests\Exception\Http;
+use WpOrg\Requests\Utility\HttpStatus;
 
 /**
  * Exception for 500 Internal Server Error responses
@@ -27,5 +28,5 @@ final class Status500 extends Http {
 	 *
 	 * @var string
 	 */
-	protected $reason = 'Internal Server Error';
+	protected $reason = HttpStatus::TEXT_500;
 }
diff --git a/src/Exception/Http/Status501.php b/src/Exception/Http/Status501.php
diff --git a/src/Exception/Http/Status502.php b/src/Exception/Http/Status502.php
diff --git a/src/Exception/Http/Status503.php b/src/Exception/Http/Status503.php
diff --git a/src/Exception/Http/Status504.php b/src/Exception/Http/Status504.php
diff --git a/src/Exception/Http/Status505.php b/src/Exception/Http/Status505.php
diff --git a/src/Exception/Http/Status511.php b/src/Exception/Http/Status511.php
diff --git a/tests/Fixtures/TransportMock.php b/tests/Fixtures/TransportMock.php

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`namespace WpOrg\Requests\Exception\Http;`
`9`	`9`
`10`	`10`	`use WpOrg\Requests\Exception\Http;`
	`11`	`+use WpOrg\Requests\Utility\HttpStatus;`
`11`	`12`
`12`	`13`	`/**`
`13`	`14`	`* Exception for 304 Not Modified responses`
`@@ -27,5 +28,5 @@ final class Status304 extends Http {`
`27`	`28`	`*`
`28`	`29`	`* @var string`
`29`	`30`	`*/`
`30`		`- protected $reason = 'Not Modified';`
	`31`	`+ protected $reason = HttpStatus::TEXT_304;`
`31`	`32`	`}`