Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In Report feedback page, submit button design miss match, need to fix #3056

Open
dd32 opened this issue Dec 10, 2024 · 7 comments · May be fixed by #3065
Open

In Report feedback page, submit button design miss match, need to fix #3056

dd32 opened this issue Dec 10, 2024 · 7 comments · May be fixed by #3065
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue. [Type] Bug Something isn't working on the Learn website.

Comments

@dd32
Copy link
Member

dd32 commented Dec 10, 2024

As reported in https://meta.trac.wordpress.org/ticket/7835 by @dilipom13

Hello need to fix design issue,related to submit button.
Url is : https://learn.wordpress.org/report-content-feedback/
Image

@karthick-murugan has offered information on the source:

The issue comes from the inline css code. Found the solution, but how to update the inline css or how to override this inline css? Please let me know. Thanks
Image
@dd32 dd32 added the [Type] Bug Something isn't working on the Learn website. label Dec 10, 2024
@kaitohm kaitohm added the Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. label Dec 11, 2024
@kaitohm
Copy link
Contributor

kaitohm commented Dec 11, 2024

//dev

@jonathanbossenger
Copy link
Collaborator

Thanks @dilipom13 for reporting this.

On testing today, it appears that the issue has been resolved, so I am going to close this issue. Please feel free to reopen it if the problem returns.

@dilipom13
Copy link

Thanks @dilipom13 for reporting this.

On testing today, it appears that the issue has been resolved, so I am going to close this issue. Please feel free to reopen it if the problem returns.

Welcome @jonathanbossenger

@jonathanbossenger
Copy link
Collaborator

After reviewing this issue, it appears the issue occurs after the form is submitted, and there are errors reported on the page. The div with the class "contact-form__error" as added in the HTML above the button, which causes this issue.

@jonathanbossenger jonathanbossenger added [Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue. and removed Awaiting Triage Issues awaiting triage. See Training Team handbook for how to triage issues. labels Dec 23, 2024
@karthick-murugan
Copy link

karthick-murugan commented Dec 24, 2024 •
edited
Loading

Hi @jonathanbossenger.,

Thank you reopening the ticket. I have created a patch for the issue and uploaded in the original meta trac ticket

@jonathanbossenger
Copy link
Collaborator

Hi @karthick-murugan

learn.wordpress.org doesn't use the meta trac; you can create a PR in this repository instead.

More details on contributing code to learn.wordpress.org can be found in the training team handbook here: https://make.wordpress.org/training/handbook/training-team-how-to-guides/developing-learn-wordpress/

@karthick-murugan karthick-murugan linked a pull request Dec 24, 2024 that will close this issue
Open
@karthick-murugan
Copy link

karthick-murugan commented Dec 24, 2024 •
edited
Loading

@jonathanbossenger - As per your instructions I have created a PR and linked in this issue. Please have a look at it when you get some time. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Learn Theme Website development issues related to the Learn theme. Priority - High High priority issue. [Type] Bug Something isn't working on the Learn website.
Projects
LearnWP Website Development
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Button Alignment Issue on Report Feedback Page in Learn WordPress karthick-murugan/Learn
5 participants
@jonathanbossenger @dd32 @dilipom13 @kaitohm @karthick-murugan