Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement of MIDI support [GM/GS/XG] #121

Open
jpcima opened this issue Jun 23, 2018 · 1 comment
Open

Improvement of MIDI support [GM/GS/XG] #121

jpcima opened this issue Jun 23, 2018 · 1 comment
Assignees
Milestone

Comments

@jpcima
Copy link
Collaborator

jpcima commented Jun 23, 2018

This is to record the progress and perspective of MIDI support.

I have updated the MIDI sheet of libADLMIDI, filled in the sysex support which was added, and I also added more entries for relevant GS and XG support.
Please complete with any information I may have missed.

MIDI Implementation Chart

@Wohlstand Wohlstand added this to the MIDI Support milestone Jun 23, 2018
@Wohlstand Wohlstand pinned this issue Dec 19, 2018
@Wohlstand
Copy link
Owner

Wohlstand commented Jan 3, 2021

In a talk together with @ValleyBell, I found that at me is the mistake in the XG mode:

  • XG drumsets should be recognized by only MSB=126 or MSB=127, and LSB must be ignored when MSB is equal to the drum condition.
  • Also, for MSB=64, ignore LSB too. Rely on LSB in the condition when MSB is not equal to 64, 126, and 127. MSB=64 is just a generic melodic bank, nothing special except the case it uses MSB value.
  • Also, another XG, explained by ValleyBell: for MSB*256 + LSB query, if instrument not found, fall back to MSB*256 + LSB=0, and if not found, go silent.

EDIT: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants