Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout error from statamic/cms v4.32.0 onwards (after upgrade) #164

Open
globalexport opened this issue Nov 28, 2023 · 10 comments
Open

Timeout error from statamic/cms v4.32.0 onwards (after upgrade) #164

globalexport opened this issue Nov 28, 2023 · 10 comments
Assignees
Labels
bug Something isn't working upstream

Comments

@globalexport
Copy link

globalexport commented Nov 28, 2023

Good day,

After upgrading a Statamic site from v3 to v4, I was able to isolate this addon as being incompatible to statamic from v4.32.0 onwards. The last functioning version is v4.31.0. v4.32.0 is resulting in a PHP timeout when rendering tags like

 {{ aardvark-seo:body }}

due to

$data = PageDataParser::getData(collect($this->context));

not being resolved in time.

@mkwia mkwia added bug Something isn't working awaiting review A fix has been applied, awaiting review from client labels Nov 28, 2023
@mkwia
Copy link
Member

mkwia commented Nov 28, 2023

Thank you fro your report @globalexport . The team will review this as soon as possible

@CandourDevs
Copy link

Hi @globalexport , we raised an issue to Statamic to flag what we think is causing the incompatibility. We're also working to resolve this ourselves whilst Statamic works to release the fix.

If you'd like to see further information on the raised issue, you can find more information here (statamic/cms#9105).

@mkwia mkwia added upstream and removed awaiting review A fix has been applied, awaiting review from client labels Jan 16, 2024
@duncanmcclean
Copy link

@globalexport I'm struggling to replicate the issue on the Statamic side. Are you experiencing this issue on all entries or just some of them? Are you able to replicate on a fresh site?

@globalexport
Copy link
Author

Hi @duncanmcclean
The error was on all pages because {{ aardvark-seo:body }} is included in the main layout file.
I did not test it on a fresh install at the time because of the evident change of behavior between upgrades of Statamic.

I can confirm now that it is not happening when adding aardvark tags into the layout of an empty installation. It probably needs other cms elements to be active to enforce the timeout.

I am going to replicate the error in a few days to find out more about the state shortly before the timeout.

@duncanmcclean
Copy link

@globalexport Were you able to replicate the error in a fresh site?

@globalexport
Copy link
Author

Hi @duncanmcclean !
Sorry, that I did not inform you about the latest development.

As mentioned in my last post, I was not able to reproduce the issue in a fresh site. I planned to dig into the project more thoroughly, but needed to hand over the affected project to the client. I am unsure at this time when I can continue to work on this project.

It seems to be a tricky edge-case possibly related to the replicator component which was quite complex in the project.

Should I keep the issue open? @CandourDevs @mkwia ?

@schrmc14
Copy link

I'm running into the same issue and have reverted back to v4.31. While I haven't dug into it further, my case somewhat fits what's mentioned here >> statamic/cms#9105 (comment) in that I do have something like Bard > Fieldset > Replicator > Fieldset > Replicator > Fieldset > Link (many nested replicators with a Link)

@leganz
Copy link

leganz commented May 8, 2024

Is there any update on that? We are still stuck with version 4.31 and would like to continue update to the latest statamic version. But this problems blocks that unfortunately :/

@CandourDevs
Copy link

Thank you for the comments and additional information.

We will be reviewing this ticket more closely later this month and will send you an update shortly.

@novu-developers
Copy link

Just wanted to confirm this issue. We're also stuck here on 4.31, and would like to move forward to the latest 4.x version. Please, also consider adding support for Statamic 5. @CandourDevs Thanks for all your effort on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

8 participants