Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][SHITHRI] Shithri-Neera unjoin-rejoing may cause a loop #16

Open
Udiknedormin opened this issue Dec 29, 2022 · 0 comments
Open

[BUG][SHITHRI] Shithri-Neera unjoin-rejoing may cause a loop #16

Udiknedormin opened this issue Dec 29, 2022 · 0 comments
Labels
bug Something isn't working romance shithri

Comments

@Udiknedormin
Copy link
Collaborator

Detected issues:

  • If you un-join Shithri or Neera in another location, the other will go to their respective place of meeting instantly; I can see no way to implement "go to the same location as" though. It may be considered a corner-case though, as un-joining while in another location is generally pretty hacky and can be used to separate pairs in BG-I too.
  • Unjoining Shithri without talking to her (and then leaving the location) may lead to a loop in which Neera is unjoined, tries to talk with Player1 and if Player1 agrees to her re-joining, she's un-joined again. The loop may be broken by rejoining them in an appropriate order.

Suggested solutions:

  • "we" dialogues for both Shithri and Neera, that would override their basic ones; such a dialogue would always move both of them to the same location (probably Neera's, as it's more personal). It would have the same issues as similar dialogues in BG-I, but would work fine otherwise.
@Vakme Vakme added the bug Something isn't working label Dec 29, 2022
@Vakme Vakme changed the title bug(shithri) Shithri-Neera unjoin-rejoing may cause a loop {BUG][SHITHRI] Shithri-Neera unjoin-rejoing may cause a loop Dec 29, 2022
@Vakme Vakme added the shithri label Dec 29, 2022
@Vakme Vakme changed the title {BUG][SHITHRI] Shithri-Neera unjoin-rejoing may cause a loop [BUG][SHITHRI] Shithri-Neera unjoin-rejoing may cause a loop Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working romance shithri
Projects
None yet
Development

No branches or pull requests

2 participants