-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wont run in ubuntu 23.04 #2119
Comments
Same
Also is ie8 going to work? I really need that activex |
Do you get any different results with something like:
Ca set the lang to 'us' or something like that too to try. For the second comment, do you really want to run this as 'root'? That will probably be causing more issues than not later. |
Same,I can't run anything as non root as I'm using a chroot
|
@Chiitoo I did some tests with
So nothing changed. |
I have the exact same issue, using LANG does not help either... Any tests we could run on our end? |
I set up an Ubuntu 23.10 virtual machine, and tried installing Winetricks via apt, which got me version 20230212, and it does run. It seems it does so due to a Debian patch [1] they carry: Description: Workaround case where wine and related binaries are in /usr/bin, but wine64 is only
in Wine's bindir.
Author: Jens Reyer <[email protected]>
Forwarded: https://github.com/Winetricks/winetricks/pull/2035
Last-Update: 2023-02-26
--- a/src/winetricks
+++ b/src/winetricks
@@ -4922,10 +4922,17 @@ winetricks_set_wineprefix()
elif command -v "${WINE}64" >/dev/null 2>&1; then
WINE64="${WINE}64"
else
- # Handle case where wine binaries (or binary wrappers) have a suffix
- WINE64="$(dirname "${WINE}")/"
- [ "${WINE64}" = "./" ] && WINE64=""
- WINE64="${WINE64}$(basename "${WINE}" | sed 's/^wine/wine64/')"
+ WINE_BINDIR="$(dirname "$(readlink -f /usr/bin/wineboot 2>/dev/null)" 2>/dev/null)"
+ if [ -x "${WINE_BINDIR}/wine64" ]; then
+ # Workaround case where wine and related binaries are in /usr/bin, but wine64 is only
+ # in Wine's bindir
+ WINE64="${WINE_BINDIR}/wine64"
+ else
+ # Handle case where wine binaries (or binary wrappers) have a suffix
+ WINE64="$(dirname "${WINE}")/"
+ [ "${WINE64}" = "./" ] && WINE64=""
+ WINE64="${WINE64}$(basename "${WINE}" | sed 's/^wine/wine64/')"
+ fi
fi
WINE_ARCH="${WINE64}"
WINE_MULTI="${WINE}" This change seems to already be under review here: |
I can confirm after adding this patch, it now works correctly. |
Hello I just upgraded from 23.04 to 23.10 and this issue doesn't exist for me anymore. It looks like it's rather an Ubuntu packaging issue than a winetricks one. |
It should not be closed :/ |
Yeah, I think this can remain open at least until the linked PR is handled, since the issue does prevent running Winetricks without modifications (aside from the packaged one, since that comes with the patche). |
Here are repro steps for Debian:
Inside Docker container:
Now run:
I've tested
but I've tested PR #2035 and it seems to work fine:
|
IMO this is a Debian packaging bug (which they work around by carrying their own patch). There are similar issues with some other wrappers (protontricks, nixos, according to #2183), but as I wrote there, this is due to their wrappers. I consider it a WONTFIX. There are a lot of things a wrapper could do, and I don't think it will be trivial to solve this in a generic way. If someone has an idea on how to do that, please submit a PR. |
There is PR at #2035 which I've tested and solved the problem on Debian, is it going to be considered? |
Not in its current form, as it only fixes things for Debian and would break older macOS / possibly other platforms (which I wrote on the PR, but haven't seen any updates). |
…ne64' into WinetricksGH-2119-fix * jre-wine/Workaround_missing_/usr/bin/wine64: Workaround missing /usr/bin/wine64.
simply running winetricks won't open the gui. Removing .wine didn't help.
wine version: wine-8.0 (Ubuntu 8.0~repack-4)
it says:
warning: wine cmd.exe /c echo '%AppData%' returned empty string, error message ""
interestingly, when i copy paste the command in the warning into terminal it gives me a string like this:
The text was updated successfully, but these errors were encountered: