Skip to content

Commit abd501a

Browse files
author
Weronika Rudnicka
authored
Merge pull request #104 from Wikia/XW-2346
XW-2346 | removed font fallbacks for Chinese
2 parents 0354dc3 + 8d23479 commit abd501a

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

app/templates/base-styles/typography.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<section>
1515
<h2 id="font-family">Font Family</h2>
1616
<p>For highest browser compatibility we decided to follow direction described in <a href="https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/">Using System UI Fonts In Web Design: A Quick Practical Guide</a>. It provides a list of font-families for browsers to fallback. We listed font-families supported by major operating systems and finally we fall back to <code>sans-serif</code>. This way we can avoid web-font delivery process which would hit page performance.</p>
17-
<code><span class="format-code">$wds-font-family</span>: 'Helvetica Neue', Helvetica, Arial, 'PingFang SC', 'Hiragino Sans GB', 冬青黑体, 'Microsoft YaHei', 微软雅黑体, sans-serif;</code>
17+
<code><span class="format-code">$wds-font-family</span>: 'Helvetica Neue', Helvetica, Arial, sans-serif;</code>
1818
</section>
1919

2020
<section>

dist/scss/wds-variables/_typography.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Font family - see https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/
2-
$wds-font-family: 'Helvetica Neue', Helvetica, Arial, 'PingFang SC', 'Hiragino Sans GB', 冬青黑体, 'Microsoft YaHei', 微软雅黑体, sans-serif;
2+
$wds-font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif;
33

44
// Line height
55
$wds-line-height: 1.5em;

docs/assets/design-system.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/assets/design-system.js

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<meta name="viewport" content="width=device-width, initial-scale=1">
99

1010

11-
<meta name="design-system/config/environment" content="%7B%22modulePrefix%22%3A%22design-system%22%2C%22environment%22%3A%22production%22%2C%22rootURL%22%3A%22/%22%2C%22locationType%22%3A%22hash%22%2C%22EmberENV%22%3A%7B%22FEATURES%22%3A%7B%7D%7D%2C%22APP%22%3A%7B%22name%22%3A%22design-system%22%2C%22version%22%3A%223.0.0+9b2045b0%22%7D%2C%22exportApplicationGlobal%22%3Afalse%7D" />
11+
<meta name="design-system/config/environment" content="%7B%22modulePrefix%22%3A%22design-system%22%2C%22environment%22%3A%22production%22%2C%22rootURL%22%3A%22/%22%2C%22locationType%22%3A%22hash%22%2C%22EmberENV%22%3A%7B%22FEATURES%22%3A%7B%7D%7D%2C%22APP%22%3A%7B%22name%22%3A%22design-system%22%2C%22version%22%3A%224.1.0%22%7D%2C%22exportApplicationGlobal%22%3Afalse%7D" />
1212

1313
<link rel="stylesheet" href="/assets/vendor.css">
1414
<link rel="stylesheet" href="/assets/design-system.css">

style-guide/styles/wds-variables/_typography.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// Font family - see https://www.smashingmagazine.com/2015/11/using-system-ui-fonts-practical-guide/
2-
$wds-font-family: 'Helvetica Neue', Helvetica, Arial, 'PingFang SC', 'Hiragino Sans GB', 冬青黑体, 'Microsoft YaHei', 微软雅黑体, sans-serif;
2+
$wds-font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif;
33

44
// Line height
55
$wds-line-height: 1.5em;

0 commit comments

Comments
 (0)