Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink Development Server #5

Open
rajadain opened this issue Oct 5, 2016 · 1 comment
Open

Rethink Development Server #5

rajadain opened this issue Oct 5, 2016 · 1 comment

Comments

@rajadain
Copy link
Member

rajadain commented Oct 5, 2016

Currently the bundle.sh scripts writes to the /dist folder, and server.sh serves from the /dist folder. Since the /dist folder is used to push to production, it shouldn't have development-time artifacts such as source maps or unminified styles / scripts. Consider altering the project structure so that the development setup is served from elsewhere, and /dist only used for production deploys.

Context from #2:

Maybe we shouldn't be exporting to the /dist folder and serving from there for development? This was the easiest thing to do right now, but I feel /dist should only be used for production builds.

@kdeloach
Copy link

kdeloach commented Oct 5, 2016

I don't think there's anything wrong with this. We should be able to generate a different set of artifacts based on the target environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants