Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate until no records or limit #41

Open
ferrumboll opened this issue Jan 17, 2024 · 3 comments
Open

Paginate until no records or limit #41

ferrumboll opened this issue Jan 17, 2024 · 3 comments

Comments

@ferrumboll
Copy link

Hello,
There are some APIs that don't have a next page identifier in the response, the only way is to keep querying until a manual limit or until the API gives 0 items.

Is this possible with this Tap?

@ferrumboll
Copy link
Author

I could try to do a PR with an extra Paginator for this, if it is not possible right now.

@jlloyd-widen
Copy link
Contributor

I do not believe that is supported, so if you are able to add a PR, that would be the quickest path to adding support for it.

@edgarrmondragon
Copy link
Contributor

fwiw starting with 0.35.0 (see meltano/sdk#1918) the sdk will exit the pagination loop if the page contains no records :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants