Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Odities in English "translations"? #2177

Open
Naheulf opened this issue Mar 21, 2025 · 0 comments
Open

[Lang] Odities in English "translations"? #2177

Naheulf opened this issue Mar 21, 2025 · 0 comments

Comments

@Naheulf
Copy link

Naheulf commented Mar 21, 2025

Trying to review #2171 I compare the “originals” en_US.json files with the proposed translations. However, I found few things that seem odd to me.

Warning

As I'm not English native speaker, some oddities reported here may be totaly wrong!

Menu path quoting

There are inconsistencies in how menu paths are included in these achievements descriptions:

"hex.builtin.achievement.starting_out.docs.desc": "Open the documentation by selecting Help -> Documentation from the menu bar.",

"hex.builtin.achievement.patterns.load_existing.desc": "Load a pattern that has been created by someone else by using the 'File -> Import' menu.",

The former include them as plain text, while the latter use quotes around the path. Which one should be used? (I think both should use the quoted paths.)

Singular or plural, this is/are the question(s)

In the following text, I think there is an inconsistency in the use of singular vs. plural:

"hex.builtin.achievement.patterns.modify_data.desc": "Modify the underlying bytes of a pattern by double-clicking its value in the pattern data view and entering a new value.",

For me, either you modify “a byte by clicking its value” or you modify “bytes by clicking their values”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant