Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTMLAnchorElement is missing pathname #151

Open
damienwebdev opened this issue Aug 1, 2022 · 5 comments
Open

HTMLAnchorElement is missing pathname #151

damienwebdev opened this issue Aug 1, 2022 · 5 comments

Comments

@damienwebdev
Copy link

https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement/pathname

@damienwebdev
Copy link
Author

Read through: #103 I assume this is out of scope.

@WebReflection
Copy link
Owner

@damienwebdev not sure what has that thread to do with your request ... that thread is about evaluating JavaScript and provide global APIs in here ... your request is about a link attribute?

@WebReflection WebReflection reopened this Aug 1, 2022
@WebReflection
Copy link
Owner

P.S. the file would be different, it'd be the HTMLAnchorElement instead, but the concept is the same:
#143 (comment)

These kind of requests keep landing without issues as long as contributors are willing to help out 👍

@damienwebdev
Copy link
Author

damienwebdev commented Aug 3, 2022

if you would like to provide a lazy accessor for history or others API, as long as it’s lazy and doesn’t change anything else around this project, I’d be more than happy to have a look, but if your goal is to have JS running within linkedom documents, I recommend you go back to JSDOM or use cypress, puppeteer, or others solutions.

This is exactly my use-case, I'm trying to SSR an Angular app with Linkedom (which I have been surprisingly successful with - it's quite fast too!) But I had to make some amendments to get there.

I figured, since this was such an amendment specifically for that use case it was out of the scope of this library.

@WebReflection
Copy link
Owner

@damienwebdev I don't know why you brought that quote here in a completely unrelated issue ... my answer here was about you needing to send a PR to apply that change that has nothing to do with what you quoted there.

If you won't do that, it's OK, close this again, and let's move forward ... if you do, please don't bring to this issue completely unrelated discussions as that doesn't help anyone, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants