Merge pull request #60 from WebCoder49/disabled-attribute

Fix HTML attribute synchronisation
WebCoder49 · Oct 7, 2023 · 234d4ec · 234d4ec
2 parents 0242a75 + ed6b156
commit 234d4ec
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 27 deletions.
diff --git a/code-input.js b/code-input.js
@@ -31,13 +31,28 @@ var codeInput = {
     textareaSyncAttributes: [
         "aria-*",
         "value",
-        "name",
         // Form validation - https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#using_built-in_form_validation
-        "required",
-        "minlength", "maxlength",
         "min", "max",
         "type",
-        "pattern"
+        "pattern",
+
+        // Source: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea
+        "autocomplete", 
+        "autocorrect", 
+        "autofocus",
+        "cols",
+        "dirname",
+        "disabled",
+        "form",
+        "maxlength",
+        "minlength",
+        "name",
+        "placeholder",
+        "readonly",
+        "required",
+        "rows",
+        "spellcheck",
+        "wrap"
     ],
 
     /**
@@ -777,7 +792,8 @@ var codeInput = {
                         break;
                     default:
                         if (codeInput.textareaSyncAttributes.includes(name)) {
-                            if(newValue == null) {
+                            console.log("sync", name, oldValue, newValue);
+                            if(newValue == null || newValue == undefined) { // TODO: Console.Log to check reaches here with disabled attribute; Fix for disabled attr removal
                                 this.textareaElement.removeAttribute(name);
                             } else {
                                 this.textareaElement.setAttribute(name, newValue);
@@ -939,27 +955,6 @@ var codeInput = {
             return this.textareaElement.reportValidity();
         }
 
-
-        /**
-         * @override
-         */
-        setAttribute(qualifiedName, value) {
-            super.setAttribute(qualifiedName, value); // code-input
-            if(this.textareaElement != null) {
-                this.textareaElement.setAttribute(qualifiedName, value); // textarea
-            }
-        }
-
-        /**
-         * @override
-         */
-        getAttribute(qualifiedName) {
-            if (this.textareaElement == null) {
-                return super.getAttribute(qualifiedName);
-            }
-            return this.textareaElement.getAttribute(qualifiedName); // textarea
-        }
-
         /**
          * Allows plugins to store data in the scope of a single element.
          * Key - name of the plugin

diff --git a/package.json b/package.json
@@ -4,7 +4,7 @@
   "description": "Fully customisable, editable syntax-highlighted textareas.",
   "browser": "code-input.js",
   "scripts": {
-    "test": "echo \"Error: no test specified\" && exit 1"
+    "test": "echo \"This is a front-end library, not a Node library. Please see the README for how to use.\" && exit 1"
   },
   "repository": {
     "type": "git",