Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line length limits are easily exceeded on Windows #514

Open
alexcrichton opened this issue Jul 15, 2024 · 1 comment
Open

Command line length limits are easily exceeded on Windows #514

alexcrichton opened this issue Jul 15, 2024 · 1 comment

Comments

@alexcrichton
Copy link
Collaborator

This line in the header file is quite large and can quickly run into command line length limits on Windows. I've debugged this a few times on wasi-sdk PRs now and some rough math shows:

  • Command line length limits are ~8192 bytes on Windows by default
  • 86 header files, adding up to 4778 bytes, are removed in that line
  • This leaves roughly 39 bytes for the install prefix to be able to work correctly

A build prefix such as D:/a/wasi-sdk/wasi-sdk/build/sysroot/install just exceeds this limit. Apparently the failure mode is that this command line is silently truncated and files aren't removed. This leads to errors elsewhere in the build where it depended on files being removed.

@sbc100
Copy link
Member

sbc100 commented Jul 15, 2024

So frustrating...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants