Skip to content

Commit 39bf87e

Browse files
authored
Don't strip target features in wasm-emscripten-finalize (#7043)
This makes the behavior consistent with emcc builds where we don't run finalization, and potentially makes testing and debugging easier. Emscripten still strips the target features section when optimizing.
1 parent a0f77ad commit 39bf87e

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

src/tools/wasm-emscripten-finalize.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -266,8 +266,6 @@ int main(int argc, const char* argv[]) {
266266
passRunner.add("legalize-js-interface");
267267
}
268268

269-
passRunner.add("strip-target-features");
270-
271269
// If DWARF is unused, strip it out. This avoids us keeping it alive
272270
// until wasm-opt strips it later.
273271
if (!DWARF) {

test/lld/em_asm_pthread.wasm.out

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12830,4 +12830,5 @@
1283012830
)
1283112831
)
1283212832
;; custom section "producers", size 172
12833+
;; features section: threads, mutable-globals, bulk-memory, sign-ext
1283312834
)

0 commit comments

Comments
 (0)