Remove Preview1's advice about random-number generators. #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the preview1 documentation for the `random_get` function said: > This function may execute slowly, so when large mounts of random data are > required, it's advisable to use this function to seed a pseudo-random > number generator, rather than to provide the random data directly. However, Wasm guest code is unaware of VM forks in any VMs might be running in, as well as snapshot/resume features offered by some Wasm engines and tools, so in practice, WASI use cases have tended toward using `random_get` in place of guest PRNGs, and thus to relying on `random_get` executing quickly. This pattern seems sufficiently widely applicable to motivate updating WASIp1 to reflect it. To be sure, this is not a behavior change; it's just removing what we now understand to be bad advice in general. WASIp2 for its part has already made a similar change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the preview1 documentation for the
random_getfunction said:However, Wasm guest code is unaware of VM forks in any VMs might be running in, as well as snapshot/resume features offered by some Wasm engines and tools, so in practice, WASI use cases have tended toward using
random_getin place of guest PRNGs, and thus to relying onrandom_getexecuting quickly.This pattern seems sufficiently widely applicable to motivate updating WASIp1 to reflect it. To be sure, this is not a behavior change; it's just removing what we now understand to be bad advice in general.
WASIp2 for its part has already made a similar change.