Skip to content

Commit 55f67b5

Browse files
Merge pull request #69 from WeareJH/feature/adding-some-indexes-to-optimise-table-search
Adding some indexes for common conditions used for searching
2 parents 35de3a5 + 85d76aa commit 55f67b5

File tree

2 files changed

+37
-1
lines changed

2 files changed

+37
-1
lines changed

src/Setup/UpgradeSchema.php

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,14 @@
22

33
namespace Jh\Import\Setup;
44

5+
use Magento\Framework\DB\Adapter\AdapterInterface;
56
use Magento\Framework\DB\Ddl\Table;
67
use Magento\Framework\Setup\ModuleContextInterface;
78
use Magento\Framework\Setup\SchemaSetupInterface;
89
use Magento\Framework\Setup\UpgradeSchemaInterface;
910

11+
use function array_key_exists;
12+
1013
/**
1114
* @author Aydin Hassan <[email protected]>
1215
*/
@@ -305,6 +308,39 @@ public function upgrade(SchemaSetupInterface $setup, ModuleContextInterface $con
305308
$setup->getConnection()->createTable($csvArchiveTable);
306309
}
307310

311+
if (version_compare($context->getVersion(), '2.5.6', '<')) {
312+
$connection = $setup->getConnection();
313+
$tableName = $setup->getTable('jh_import_history');
314+
$fieldName = 'import_name';
315+
$indexName = $setup->getIdxName($tableName, $fieldName, AdapterInterface::INDEX_TYPE_INDEX);
316+
317+
$indexesList = $connection->getIndexList($tableName);
318+
319+
if (!array_key_exists($indexName, $indexesList)) {
320+
$connection->addIndex(
321+
$tableName,
322+
$indexName,
323+
[$fieldName],
324+
AdapterInterface::INDEX_TYPE_INDEX
325+
);
326+
}
327+
328+
$tableName = $setup->getTable('jh_import_history_item_log');
329+
$fieldName = 'id_value';
330+
$indexName = $setup->getIdxName($tableName, $fieldName, AdapterInterface::INDEX_TYPE_INDEX);
331+
332+
$indexesList = $connection->getIndexList($tableName);
333+
334+
if (!array_key_exists($indexName, $indexesList)) {
335+
$connection->addIndex(
336+
$tableName,
337+
$indexName,
338+
[$fieldName],
339+
AdapterInterface::INDEX_TYPE_INDEX
340+
);
341+
}
342+
}
343+
308344
$setup->endSetup();
309345
}
310346
}

src/etc/module.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
<?xml version="1.0"?>
22
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
3-
<module name="Jh_Import" setup_version="1.8.0"/>
3+
<module name="Jh_Import" setup_version="2.5.6"/>
44
</config>

0 commit comments

Comments
 (0)