Skip to content

Commit 2a55478

Browse files
authored
Merge pull request #63 from WeareJH/add-success-return-to-all-cli-commands
Add success return to all cli commands
2 parents 48fb6f5 + 2c98104 commit 2a55478

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

src/Command/ClearLastImportLogCommand.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Jh\Import\Config\Data;
66
use Jh\Import\Entity\ImportHistoryResource;
77
use Magento\Framework\App\ResourceConnection;
8+
use Magento\Framework\Console\Cli;
89
use Magento\Framework\DB\Adapter\AdapterInterface;
910
use Magento\Framework\View\Element\UiComponent\DataProvider\CollectionFactory;
1011
use Symfony\Component\Console\Command\Command;
@@ -84,5 +85,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
8485
$importName
8586
)
8687
);
88+
89+
return Cli::RETURN_SUCCESS;
8790
}
8891
}

src/Command/ListImportsCommand.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
use Jh\Import\Config\Data;
66
use Jh\Import\Locker\Locker;
77
use Magento\Cron\Model\Config;
8+
use Magento\Framework\Console\Cli;
89
use Symfony\Component\Console\Command\Command;
910
use Symfony\Component\Console\Helper\Table;
1011
use Symfony\Component\Console\Input\InputArgument;
@@ -78,5 +79,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
7879
->render();
7980

8081
$output->writeln('');
82+
83+
return Cli::RETURN_SUCCESS;
8184
}
8285
}

src/Command/UnlockImportCommand.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Jh\Import\Config\Data;
66
use Jh\Import\Locker\Locker;
7+
use Magento\Framework\Console\Cli;
78
use Symfony\Component\Console\Command\Command;
89
use Symfony\Component\Console\Input\InputArgument;
910
use Symfony\Component\Console\Input\InputInterface;
@@ -54,5 +55,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
5455

5556
$this->locker->release($importName);
5657
$output->writeln(sprintf('<info>The lock for import: "%s" has been released</info>', $importName));
58+
59+
return Cli::RETURN_SUCCESS;
5760
}
5861
}

src/Command/ViewLocksCommand.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
use Jh\Import\Config\Data;
66
use Jh\Import\Locker\Locker;
7+
use Magento\Framework\Console\Cli;
78
use Symfony\Component\Console\Command\Command;
89
use Symfony\Component\Console\Helper\Table;
910
use Symfony\Component\Console\Input\InputInterface;
@@ -63,5 +64,7 @@ function (string $importName) {
6364
->render();
6465

6566
$output->writeln('');
67+
68+
return Cli::RETURN_SUCCESS;
6669
}
6770
}

src/Command/ViewLogsCommand.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
namespace Jh\Import\Command;
44

55
use Jh\Import\Config\Data;
6+
use Magento\Framework\Console\Cli;
67
use Magento\Framework\View\Element\UiComponent\DataProvider\CollectionFactory;
78
use Symfony\Component\Console\Command\Command;
89
use Symfony\Component\Console\Helper\Table;
@@ -122,5 +123,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
122123
];
123124
}, $itemLogCollection->getItems()))
124125
->render();
126+
127+
return Cli::RETURN_SUCCESS;
125128
}
126129
}

0 commit comments

Comments
 (0)