Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptionsPrivate.CreateFrame could do less on /wa command #5206

Closed
mrbuds opened this issue Jul 4, 2024 · 0 comments
Closed

OptionsPrivate.CreateFrame could do less on /wa command #5206

mrbuds opened this issue Jul 4, 2024 · 0 comments
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. ✨Housekeeping Chores which need doing, like travis config, dependencies, or changing data to keep up with patches.

Comments

@mrbuds
Copy link
Contributor

mrbuds commented Jul 4, 2024

OptionsPrivate.CreateFrame could create less frames

https://github.com/WeakAuras/WeakAuras2/blob/main/WeakAurasOptions/OptionsFrames/OptionsFrame.lua#L513-L520

  frame.texturePicker = OptionsPrivate.TexturePicker(frame)
  frame.iconPicker = OptionsPrivate.IconPicker(frame)
  frame.modelPicker = OptionsPrivate.ModelPicker(frame)
  frame.importexport = OptionsPrivate.ImportExport(frame)
  frame.texteditor = OptionsPrivate.TextEditor(frame)
  frame.codereview = OptionsPrivate.CodeReview(frame)
  frame.update = OptionsPrivate.UpdateFrame(frame)
  frame.debugLog = OptionsPrivate.DebugLog(frame)

This execute quite a lot of code that is not needed right now, there is room for some refactoring
@mrbuds mrbuds added the ✨Housekeeping Chores which need doing, like travis config, dependencies, or changing data to keep up with patches. label Jul 4, 2024
@github-actions github-actions bot added the ⏱ Awaiting Response This ticket hasn't been triaged yet. label Jul 4, 2024
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Jul 4, 2024
@mrbuds
Dont't construct unnecessary frames when opening /wa
e7f6ab3 
fixes  WeakAuras#5206
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Jul 4, 2024
@mrbuds
Dont't construct unnecessary frames when opening /wa
71676de 
fixes  WeakAuras#5206
mrbuds added a commit to mrbuds/WeakAuras2 that referenced this issue Jul 4, 2024
@mrbuds
Dont't construct unnecessary frames when opening /wa
15ec826 
fixes  WeakAuras#5206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⏱ Awaiting Response This ticket hasn't been triaged yet. ✨Housekeeping Chores which need doing, like travis config, dependencies, or changing data to keep up with patches.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrbuds