move: Use post input signal for touch move grabs (#2508)

soreau · web-flow · commit ea5118a7a989 · 2024-11-12T14:32:26.000+01:00
Without this, touch fingers are not set yet which causes a visual jump when attempting to move drag a window with touchscreen devices. Use post signal so that the fingers are properly detected and the correct coordinates are used in the first place. Fixes #2505.
diff --git a/plugins/single_plugins/move.cpp b/plugins/single_plugins/move.cpp
@@ -144,8 +144,8 @@ class wayfire_move : public wf::per_output_plugin_instance_t,
         }
     };
 
-    wf::signal::connection_t<wf::input_event_signal<wlr_touch_down_event>> on_raw_touch_down =
-        [=] (wf::input_event_signal<wlr_touch_down_event> *ev)
+    wf::signal::connection_t<wf::post_input_event_signal<wlr_touch_down_event>> on_raw_touch_down =
+        [=] (wf::post_input_event_signal<wlr_touch_down_event> *ev)
     {
         if (ev->event->touch_id == 0)
         {

Original file line number	Diff line number	Diff line change
`@@ -144,8 +144,8 @@ class wayfire_move : public wf::per_output_plugin_instance_t,`
`144`	`144`	`}`
`145`	`145`	`};`
`146`	`146`
`147`		`- wf::signal::connection_t<wf::input_event_signal<wlr_touch_down_event>> on_raw_touch_down =`
`148`		`- [=] (wf::input_event_signal<wlr_touch_down_event> *ev)`
	`147`	`+ wf::signal::connection_t<wf::post_input_event_signal<wlr_touch_down_event>> on_raw_touch_down =`
	`148`	`+ [=] (wf::post_input_event_signal<wlr_touch_down_event> *ev)`
`149`	`149`	`{`
`150`	`150`	`if (ev->event->touch_id == 0)`
`151`	`151`	`{`