-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treatment of statements is inconsistent #150
Closed
markwhiting opened this issue
Jun 11, 2024
· 2 comments
· May be fixed by Watts-Lab/commonsense-statements#24
Closed
Treatment of statements is inconsistent #150
markwhiting opened this issue
Jun 11, 2024
· 2 comments
· May be fixed by Watts-Lab/commonsense-statements#24
Labels
bug
Something isn't working
Comments
Steps:
blockers:
|
Goals is to make the presentation consistent, more than to make it any one specific format.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This likely has 2 layers:
I think the behavior we would like is that statements should be stored in a consistent state (i.e., all have trailing punctuation and capitalization or all not have those things) and displayed in a consistent way (i.e., always shown with the first letter capitalized and a period at the end).
Additionally, I think we want to clean up any existing statements that have these issues without breaking IDs.
To be finished, we should have a test in place that checks that statements are correctly formatted after ingestion and are correctly formatted at render time.
The text was updated successfully, but these errors were encountered: