chore: dotenv integrations update #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated `package.json`: - Added `dotenv` library (`^16.4.7`) as a new dependency. This enables the use of environment variables to enhance configuration management and improve project flexibility.
- `.env.vault`: Updated secrets and versions for `development`, `ci`, and `staging` environments. - `DOTENV_VAULT_DEVELOPMENT`: Replaced secret and updated to version 2. - `DOTENV_VAULT_CI`: Replaced secret and updated to version 3. - `DOTENV_VAULT_STAGING`: Replaced secret and updated to version 2.
- Updated `finance-earn-tokens.tsx` to use `EARN_TOKEN_SERVICE_URL` from `GLOBAL_CONSTANTS` instead of hardcoding the URL. - Added `EARN_TOKEN_SERVICE_URL` constant definition in `config-global.ts` with fallback to environment variables. This ensures better maintainability and configuration flexibility.
cswni
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #538 +/- ##
========================================
+ Coverage 0.03% 8.30% +8.26%
========================================
Files 557 558 +1
Lines 30734 30752 +18
Branches 557 618 +61
========================================
+ Hits 11 2553 +2542
+ Misses 30167 27729 -2438
+ Partials 556 470 -86 ☔ View full report in Codecov by Sentry. |
- Create `src/test/config-global.test.ts` to validate the presence of critical properties in `GLOBAL_CONSTANTS`. - Ensure all required properties, such as `MMC_ADDRESS`, `EMAIL_API_KEY`, and `BASE_URL`, are defined.
- Export `FinanceEarnTokensProps` for external usage in other modules/files. - Add `data-testid="earn-tokens-image"` to the relevant `Stack` component for improved testability in `finance-earn-tokens.tsx`.
- Updated `setupTest.ts` to include `vi` from `vitest` and mock `react-i18next`. - Added a `__mocks__/react-i18next.js` file to mock `useTranslation`, providing basic functionality for `t` and `i18n`. This ensures compatibility in tests that rely on i18n translations.
- Created `finance-earn-token.test.tsx` to cover functionality. - Verified snapshot rendering for consistent UI structure. - Tested presence and correctness of title, subtitle, and description. - Ensured button click triggers `window.open` with expected URL. - Confirmed image visibility on large screens.
|
This was
linked to
issues
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates and improvements across multiple files, focusing on configuration changes, dependency updates, and enhancements to the codebase. The most important changes include updates to environment variables, workflow adjustments, and the addition of a code coverage badge.
Environment and configuration updates:
.env.vault: Updated the development, CI, staging, and production vault keys and their respective versions.Workflow adjustments:
.github/workflows/ci.yml: Removed the build analysis step from the CI workflow..github/workflows/release.yml: Renamed the release job to "Semver Release" for clarity.Dependency updates:
package.json: Added thedotenvpackage as a new dependency.Documentation and testing improvements:
README.md: Added a Codecov badge to the README file to display code coverage status.setupTest.ts: Added a mock for thereact-i18nextmodule to improve testing.This pull request includes multiple changes across various files to update environment variables, improve CI workflows, add a badge to the README, and update dependencies.Environment Variables:
DOTENV_VAULT_DEVELOPMENT,DOTENV_VAULT_CI,DOTENV_VAULT_STAGING,DOTENV_VAULT_PRODUCTIONand their versions in.env.vault.CI Workflow Improvements:
.github/workflows/ci.yml..github/workflows/release.yml.Documentation:
README.mdfile.Dependencies:
dotenvpackage topackage.json.Codebase Updates:
handleClickfunction insrc/sections/finance/components/finance-earn-tokens.tsxand added a TODO comment to move it to environment variables.codecovVitePluginconfiguration invite.config.tsafter thenodePolyfillsplugin.