Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluding one Nidoran causes all Nidoran to disappear #254

Open
Mygod opened this issue Oct 17, 2020 · 3 comments
Open

Excluding one Nidoran causes all Nidoran to disappear #254

Mygod opened this issue Oct 17, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@Mygod
Copy link
Contributor

Mygod commented Oct 17, 2020

Edge case: both Nidoran have the same form NIDORAN_NORMAL.

@versx
Copy link
Collaborator

versx commented Nov 18, 2020

What would you propose we do to get around this?
Maybe appending -m or -f to the id-form if Nidoran, although this adds boilerplate code to our Pokemon functions when we loop ids and forms.

@Mygod
Copy link
Contributor Author

Mygod commented Nov 18, 2020

I think we just need to associate each form with its Pokemon ID, instead of just doing the hacky way by only checking form. This way it prevents other edge cases popping up in the future too...

@versx
Copy link
Collaborator

versx commented Nov 18, 2020

I think we just need to associate each form with its Pokemon ID, instead of just doing the hacky way by only checking form. This way it prevents other edge cases popping up in the future too...

That makes sense.

@versx versx added the bug Something isn't working label Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants