Polls Webhooks

Motivation:
Chuck would continue attempting to send webhooks and logging every single one of them, causing stability issues due to the sheer number of logs being generated every second.

This polls the webhooks every interval (5s default) set in the config to check if they're online. If they aren't online, the webhooks aren't sent, increasing stability.

Author: TurtIeSocks

README.md

@@ -90,7 +90,8 @@ SELECT name, type, data FROM rdmdb.instance;
         "enabled": false,
         "urls": ["http://127.0.0.1:9003"],
         "delay": 5,
-        "retryCount": 5
+        "retryCount": 5,
+        "polling": 5
     },
     "logs": {
         "level": 4,

package-lock.json

@@ -64,7 +64,8 @@
             "http://127.0.0.1:9002"
         ],
         "delay": 5,
-        "retryCount": 5
+        "retryCount": 5,
+        "polling": 5
     },
     "logs": {
         "level": 4,

src/configs/default.json

@@ -78,6 +78,7 @@ require('./services/logger.js');
 
         if (config.webhooks.enabled && config.webhooks.urls.length > 0) {
             WebhookController.instance.start();
+            WebhookController.instance.checkOnline();
         }
     }
 })();

src/dataparser.js

@@ -1,25 +1,27 @@
 'use strict';
 
 const axios = require('axios');
-const config = require('./config.js');
+const { webhooks } = require('./config.js');
 
 /**
  * WebhookController relay class.
  */
 class WebhookController {
-    static instance = new WebhookController(config.webhooks.urls, config.webhooks.delay, config.webhooks.retryCount);
+    static instance = new WebhookController(webhooks.urls, webhooks.delay, webhooks.retryCount, webhooks.polling);
 
     /**
      * Initialize new WebhookController object.
      * @param {*} urls
      * @param {number} delay
      * @param {number} retryCount
      */
-    constructor(urls, delay = 5, retryCount) {
+    constructor(urls, delay = 5, retryCount, polling) {
         console.info('[WebhookController] Starting up...');
         this.urls = urls;
         this.delay = delay;
         this.retryCount = retryCount;
+        this.polling = polling;
+        this.online = [];
         this.pokemonEvents = [];
         this.pokestopEvents = [];
         this.lureEvents = [];
@@ -37,6 +39,7 @@ class WebhookController {
      */
     start() {
         this.timer = setInterval(() => this.loopEvents(), this.delay * 1000);
+        setInterval(() => this.checkOnline(), this.polling * 1000);
     }
 
     /**
@@ -52,7 +55,7 @@ class WebhookController {
      * @param {*} pokemon 
      */
     addPokemonEvent(pokemon) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.pokemonEvents.push(pokemon);
@@ -63,7 +66,7 @@ class WebhookController {
      * @param {*} pokestop 
      */
     addPokestopEvent(pokestop) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.pokestopEvents.push(pokestop);
@@ -74,7 +77,7 @@ class WebhookController {
      * @param {*} pokestop
      */
     addLureEvent(pokestop) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.lureEvents.push(pokestop);
@@ -85,7 +88,7 @@ class WebhookController {
      * @param {*} pokestop
      */
     addInvasionEvent(pokestop) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.invasionEvents.push(pokestop);
@@ -96,7 +99,7 @@ class WebhookController {
      * @param {*} pokestop
      */
     addQuestEvent(pokestop) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.questEvents.push(pokestop);
@@ -107,7 +110,7 @@ class WebhookController {
      * @param {*} gym
      */
     addGymEvent(gym) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.gymEvents.push(gym);
@@ -118,7 +121,7 @@ class WebhookController {
      * @param {*} gym
      */
     addGymInfoEvent(gym) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.gymInfoEvents.push(gym);
@@ -129,7 +132,7 @@ class WebhookController {
      * @param {*} gym
      */
     addEggEvent(gym) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.eggEvents.push(gym);
@@ -140,7 +143,7 @@ class WebhookController {
      * @param {*} gym
      */
     addRaidEvent(gym) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.raidEvents.push(gym);
@@ -151,7 +154,7 @@ class WebhookController {
      * @param {*} weather
      */
     addWeatherEvent(weather) {
-        if (!config.webhooks.enabled || this.urls.length === 0) {
+        if (!webhooks.enabled || this.urls.length === 0) {
             return;
         }
         this.weatherEvents.push(weather);
@@ -277,7 +280,7 @@ class WebhookController {
      */
     sendEvents(events, url, retryCount) {
         // If events is not set, skip..
-        if (!events) {
+        if (!events || !this.online.includes(url)) {
             return;
         }
         // axios request options
@@ -298,14 +301,37 @@ class WebhookController {
             .catch(err => {
                 if (err) {
                     if (retryCount < this.retryCount) {
-                        console.error('[WebhookController] Error occurred, trying again:', err);
+                        console.error(`[WebhookController] Error occurred, trying again for ${url}`);
                         this.sendEvents(events, url, retryCount++);
                     } else {
-                        console.error('[WebhookController] Error occurred, max retry count reached:', err);
+                        console.error(`[WebhookController] Error occurred, max retry count reached for ${url}`);
                     }
                 }
             });
     }
+
+    checkOnline() {
+        this.online = [];
+        this.urls.forEach(url => {
+            axios({
+                url: url,
+                method: 'POST',
+                data: { pokemon_id: 0 },
+                headers: {
+                  'Accept': 'application/json',
+                  'Content-Type': 'application/json',
+                  'Cache-Control': 'no-cache',
+                  'User-Agent': 'Nodedradamus',
+                },
+            })
+                .then(() => this.online.push(url))
+                .catch(err => {
+                    if (err) {
+                      console.error(`${url} is offline`);
+                    };
+                });
+          });
+    };
 }
 
 module.exports = WebhookController;