fixed->issue:147 search bar missing, reason:themes:[ Array ] in confi…

[masterghost2002]

fixed->issue:147 search bar missing, reason:themes:[ Array ] in config consisting of localsearch is over written by themes [Array] in extendedConfig

Explanation

All the changes are done in docusaurus.config.js

The reason for the search bar is not visible the, themes array [line no 62] in the config object which again consist a array of "@easyops-cn/docusaurus-search-local" the extension which is responsible for the search bar, is being overwritten by the array in extendedConfig object.

Related issue

fixes#147

What type of PR is this

/fixes
/feature-required

Proposed Changes

Merge the themes array present in the extendedConfig object which overwrites the themes array present in config object.

Live link for testing

Live Testing Link

ScreenShot

[alabulei1]

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.

---

Commit 98e068a473f43added2315205fbced0682e442f8

Key changes:

• Added the '@docusaurus/theme-mermaid' theme to the 'themes' array in the config.
• Removed the 'themes' array in the extendedConfig object and added '@docusaurus/theme-mermaid' theme to the 'themes' array in the config.

Potential problems:

• The patch does not address the issue described in the commit message ("issue:147 search bar missing"). It only adds a theme to the configuration. There might be a misunderstanding or miscommunication regarding the actual problem or solution.
• The removal of the 'themes' array in the extendedConfig object seems unnecessary and may cause unintended consequences if there are other configurations dependent on it. This change should be reviewed thoroughly to ensure it does not introduce any regressions or unexpected behavior.

[alabulei1]

Hi @masterghost2002 ，

Thank you for your contributions. Did the themes cause this problem?

[masterghost2002]

not actually the theme, in docusaurus.config.js, there is a config object which consist of themes array the place where code for @easyops-cn/docusaurus-search-local is defined, which result in the visibility of search box.

But, when we come down, to the extendedConfig object, it consist of three things, spread config object, the place where our themes (which consist the code for search) array is defined.
a markdown key, and again a themes array which consist of @docusaurus/theme-mermaid, as we are using spread operator on your config object, it placed the themes array in the extendedConfig object, which is later being replaced by the themes array which consist of docusaurus themes