Windows not actively supported?

[rhvonlehe]

Is it safe to say there aren't any users actively building this from source on Windows? It seems unlikely because I've run into too many snags. Just a few of them:

• gettext package did not complete for me without manually killing bash processes that had hung (vcpkg to blame)
• std::min, std::max are being obscured by Windows.h and/or the header is not being included. I was able to fix this.
• Line 56 of src/console.h does not compile with MSVC 2017 (or 2019 for that matter), whereas it does with gcc. I have not worked around this.

[past-due]

Every commit is built on MSVC 2019. (See: the Windows CI workflow build logs )

The exact steps used to build are in the CI_windows.yml workflow (although they do include a bunch of CI-specific stuff you can ignore).

Additionally, I personally build it on MSVC 2019 on Windows 10 fairly frequently.

Can you provide more specifics about your system? (Version of Windows, version of Qt you installed, exact version of MSVC, CMake configure parameters you used, etc.)

[rhvonlehe]

Thanks - I'll take a look at the yaml and maybe just wipe everything and try the latest. EDIT: I've done recent pulls, but maybe I'll just clone again in a separate location and try from scratch.

[rhvonlehe]

For this attempt, I did a fresh install of Visual STudio 2017 community edition. I pointed the CMAKE_PREFIX_PATH to my Qt 5.12.5 installation. CMake is 3.19.1

[past-due]

What Windows SDK version are you compiling against? (Also, we don't currently regularly test with VS 2017 - only VS 2019 - so it's possible there are a few fixes needed for compatibility with older VS.)

EDIT: I should also note that Qt headers can end up pulling in a lot, which may or may not be a factor in this, but we're in the process of eliminating Qt as a dependency entirely.

[rhvonlehe]

I can switch to 2019. The github page lists 2017 son I used that. I'll check the SDK and let you know.

…

On Sat, Dec 26, 2020, 5:51 PM pastdue ***@***.***> wrote: What Windows SDK version are you compiling against? (Also, we don't currently regularly test with VS 2017 - only VS 2019 - so it's possible there are a few fixes needed for compatibility with older VS.) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1432 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPA253N3BJNY6YMJEMBEA3SWZZHRANCNFSM4VJLPVOA> .

[rhvonlehe]

Looks like 10.0.18362.0

[past-due]

@rhvonlehe I've opened a PR to fix the one compilation error on MSVC < 16.5: #1516

Could you provide more information about the file(s)/line(s) that were triggering the std::min/max error?