From f520ccfd8e2165e5c8cb6e94c3ad99dd0f97af01 Mon Sep 17 00:00:00 2001 From: Pavel Solodovnikov Date: Sun, 20 Oct 2024 12:52:45 +0300 Subject: [PATCH] netplay: clarify the behavior of `GenericSystemErrorCategory` For OSes other than Windows, it uses `strerror()`, which is influenced by `LC_MESSAGES` system locale category. Extend the comment in `GenericSystemErrorCategory` to reflect that. Signed-off-by: Pavel Solodovnikov --- lib/netplay/error_categories.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/netplay/error_categories.h b/lib/netplay/error_categories.h index ddb98ed8815..2703c2a5e8a 100644 --- a/lib/netplay/error_categories.h +++ b/lib/netplay/error_categories.h @@ -25,6 +25,11 @@ /// /// Please see the bug https://github.com/microsoft/STL/issues/3254 for the explanation /// as to why we would need to use a custom error category (at least on Windows). +/// +/// NOTE: Currently, for OSes other than Windows, error messages are obtained via +/// `strerror()` function, which is influenced by the `LC_MESSAGES` locale category. +/// This shouldn't be a problem, though, as opposed to Windows, which suffers from the +/// aforementioned bug in MSVC STL. ///