Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/scorched/request.rb has incorrect require #42

Open
tmilker opened this issue Jan 24, 2021 · 1 comment
Open

lib/scorched/request.rb has incorrect require #42

tmilker opened this issue Jan 24, 2021 · 1 comment

Comments

@tmilker
Copy link

tmilker commented Jan 24, 2021

You updated this file for URI.unescape() obsolescence to CGI.unescape() but didn't update the require.

I believe you need to update lib/scorched/request.rb to require 'cgi' instead of require 'uri'. It took a number of my apps before I ran into one that this caused an issue on since CGI is so ubiquitous.
@Wardrop
Copy link
Owner

Wardrop commented Jan 27, 2021

Thanks for finding that. Fixed now in v1.0.2 which is now published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmilker @Wardrop