Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never work next to the exe #686

Closed
nopara73 opened this issue Sep 22, 2018 · 1 comment
Closed

Never work next to the exe #686

nopara73 opened this issue Sep 22, 2018 · 1 comment
Assignees
Labels
Milestone

Comments

@nopara73
Copy link
Contributor

nopara73 commented Sep 22, 2018

I created a Windows installer with Wix and I noticed that the software wasn't working. The reason being is that you can never work next to the exe, since that is located in the Program Files, which needs admin access and the software as launched it doesn't have that.

So, in AvalonStudio.Shell, the Extensions folder couldn't be created, thus the software failed to launch. The code below does this in AvalonStudio.

public static string ExecutionPath => Path.GetDirectoryName(Assembly.GetEntryAssembly().Location);

public static string ExtensionsFolder => Path.Combine(ExecutionPath, "Extensions");

I suggest changing the second line to this:

public static string ExtensionsFolder => Path.Combine(BaseDirectory, "Extensions");

We have the same issue with the Tor process, but I'll fix that shortly. For now, I hacked around the above issue by making my packager creating the Extensions folder and a dummy file.

Related issue: VitalElement/AvalonStudio.Shell#11

@nopara73
Copy link
Contributor Author

Done for the Tor part. Regarding Wasabi, this issue is solved (not regarding the Shell though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants