Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Standardise CredentialsProvider config between KCL and KPL #29

Open
markglh opened this issue Sep 7, 2017 · 0 comments
Open

Standardise CredentialsProvider config between KCL and KPL #29

markglh opened this issue Sep 7, 2017 · 0 comments

Comments

@markglh
Copy link
Contributor

markglh commented Sep 7, 2017

Currently the KPL requires you to pass it as an argument, whereas the KCL requires it as config.

  • Ideally we should be able to specify both as config
  • Verify that custom providers work for both the KCL and KPL

The KCL uses a different (more sophisticated) method for parsing the properties compared to the KPL, see below for an example of how it parses the CredentialsProvider:
https://github.com/awslabs/amazon-kinesis-client/blob/master/src/main/java/com/amazonaws/services/kinesis/clientlibrary/config/KinesisClientLibConfigurator.java#L112

The KPL only supports setting of Strings, Ints and Booleans:
https://github.com/awslabs/amazon-kinesis-producer/blob/master/java/amazon-kinesis-producer/src/main/java/com/amazonaws/services/kinesis/producer/KinesisProducerConfiguration.java#L197

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

1 participant