Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPCompatibilityWP to the ruleset #173

Closed
jrfnl opened this issue Aug 19, 2018 · 0 comments
Closed

Add PHPCompatibilityWP to the ruleset #173

jrfnl opened this issue Aug 19, 2018 · 0 comments

Comments

@jrfnl
Copy link
Contributor

jrfnl commented Aug 19, 2018

Once the repo has been deforked - see #169 -, the Theme Review project is free to have different dependencies than WPCS has.

This means that it will become possible to add checks for PHP cross-version compatibility using the external PHPCompatibilityWP PHPCS ruleset, which will also be used in the Tide project.

Notes for implementation:

It would be great if we could detect a potential Requires PHP header in the style.css file and use that to set the testVersion for the PHPCompatibilityWP sniffs.

If no Requires PHP header is found, the WP standard of supporting PHP 5.2 and higher should be presumed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant