Skip to content

Commit 0ffc146

Browse files
refactor(Application): Remove unnecessary imports. (#2172)
These are imported by Angular automatically
1 parent 928bfb6 commit 0ffc146

File tree

10 files changed

+76
-101
lines changed

10 files changed

+76
-101
lines changed

src/app/student/top-bar/top-bar.component.ts

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -27,24 +27,23 @@ import { MatIconModule } from '@angular/material/icon';
2727
import { ProjectLanguageChooserComponent } from '../../common/project-language-chooser/project-language-chooser.component';
2828

2929
@Component({
30-
selector: 'top-bar',
31-
imports: [
32-
CommonModule,
33-
DismissAmbientNotificationDialogModule,
34-
FlexLayoutModule,
35-
MatBadgeModule,
36-
MatButtonModule,
37-
MatDialogModule,
38-
MatIconModule,
39-
MatMenuModule,
40-
MatProgressSpinnerModule,
41-
MatToolbarModule,
42-
NotificationsDialogComponent,
43-
ProjectLanguageChooserComponent,
44-
StudentAccountMenuModule
45-
],
46-
styleUrls: ['./top-bar.component.scss'],
47-
templateUrl: 'top-bar.component.html'
30+
imports: [
31+
CommonModule,
32+
DismissAmbientNotificationDialogModule,
33+
FlexLayoutModule,
34+
MatBadgeModule,
35+
MatButtonModule,
36+
MatDialogModule,
37+
MatIconModule,
38+
MatMenuModule,
39+
MatProgressSpinnerModule,
40+
MatToolbarModule,
41+
ProjectLanguageChooserComponent,
42+
StudentAccountMenuModule
43+
],
44+
selector: 'top-bar',
45+
styleUrls: ['./top-bar.component.scss'],
46+
templateUrl: 'top-bar.component.html'
4847
})
4948
export class TopBarComponent {
5049
@ViewChild(StudentAccountMenuComponent) accountMenu: StudentAccountMenuComponent;
@@ -157,7 +156,7 @@ export class TopBarComponent {
157156
);
158157
}
159158

160-
viewAlerts($event: any): void {
159+
protected viewAlerts($event: any): void {
161160
$event.stopPropagation();
162161
this.dialog.open(NotificationsDialogComponent, {
163162
panelClass: 'dialog-sm',

src/app/teacher/select-tags/select-tags.component.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ import { MatDividerModule } from '@angular/material/divider';
88
import { MatFormFieldModule } from '@angular/material/form-field';
99
import { MatSelectModule } from '@angular/material/select';
1010
import { NgSelectModule } from '@ng-select/ng-select';
11-
import { SearchBarComponent } from '../../modules/shared/search-bar/search-bar.component';
1211
import { Tag } from '../../domain/tag';
1312
import { TagComponent } from '../tag/tag.component';
1413

1514
@Component({
15+
encapsulation: ViewEncapsulation.None,
1616
imports: [
1717
CommonModule,
1818
FormsModule,
@@ -22,10 +22,8 @@ import { TagComponent } from '../tag/tag.component';
2222
MatFormFieldModule,
2323
MatSelectModule,
2424
NgSelectModule,
25-
SearchBarComponent,
2625
TagComponent
2726
],
28-
encapsulation: ViewEncapsulation.None,
2927
selector: 'select-tags',
3028
styleUrl: './select-tags.component.scss',
3129
templateUrl: './select-tags.component.html'

src/assets/wise5/authoringTool/components/component-type-button/component-type-button.component.ts

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,24 +9,20 @@ import { MatIconModule } from '@angular/material/icon';
99
import { MatTooltipModule } from '@angular/material/tooltip';
1010

1111
@Component({
12-
imports: [
13-
ComponentInfoDialogComponent,
14-
FlexLayoutModule,
15-
MatButtonModule,
16-
MatCardModule,
17-
MatIconModule,
18-
MatTooltipModule
19-
],
20-
selector: 'component-type-button',
21-
styleUrl: './component-type-button.component.scss',
22-
templateUrl: './component-type-button.component.html'
12+
imports: [FlexLayoutModule, MatButtonModule, MatCardModule, MatIconModule, MatTooltipModule],
13+
selector: 'component-type-button',
14+
styleUrl: './component-type-button.component.scss',
15+
templateUrl: './component-type-button.component.html'
2316
})
2417
export class ComponentTypeButtonComponent {
2518
@Output() componentSelectedEvent: EventEmitter<void> = new EventEmitter<void>();
2619
@Input() componentType: string;
2720
protected label: string;
2821

29-
constructor(private componentInfoService: ComponentInfoService, private dialog: MatDialog) {}
22+
constructor(
23+
private componentInfoService: ComponentInfoService,
24+
private dialog: MatDialog
25+
) {}
3026

3127
ngOnInit(): void {
3228
const componentInfo = this.componentInfoService.getInfo(this.componentType);

src/assets/wise5/authoringTool/create-branch-paths/create-branch-paths.component.ts

Lines changed: 15 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -16,29 +16,27 @@ import { MultipleChoiceContent } from '../../components/multipleChoice/MultipleC
1616
import { CHOICE_CHOSEN_VALUE, SCORE_VALUE } from '../../../../app/domain/branchCriteria';
1717
import { ComponentContent } from '../../common/ComponentContent';
1818
import { MatSelectModule } from '@angular/material/select';
19-
import { DisplayBranchPathStepsComponent } from '../display-branch-path-steps/display-branch-path-steps.component';
2019
import { MatButtonModule } from '@angular/material/button';
2120
import { MatIconModule } from '@angular/material/icon';
2221
import { MatTooltipModule } from '@angular/material/tooltip';
2322
import { FlexLayoutModule } from '@angular/flex-layout';
2423

2524
@Component({
26-
imports: [
27-
CommonModule,
28-
DisplayBranchPathStepsComponent,
29-
FlexLayoutModule,
30-
FormsModule,
31-
MatButtonModule,
32-
MatFormFieldModule,
33-
MatIconModule,
34-
MatInputModule,
35-
MatSelectModule,
36-
MatTooltipModule,
37-
ReactiveFormsModule
38-
],
39-
selector: 'create-branch-paths',
40-
styleUrl: './create-branch-paths.component.scss',
41-
templateUrl: './create-branch-paths.component.html'
25+
imports: [
26+
CommonModule,
27+
FlexLayoutModule,
28+
FormsModule,
29+
MatButtonModule,
30+
MatFormFieldModule,
31+
MatIconModule,
32+
MatInputModule,
33+
MatSelectModule,
34+
MatTooltipModule,
35+
ReactiveFormsModule
36+
],
37+
selector: 'create-branch-paths',
38+
styleUrl: './create-branch-paths.component.scss',
39+
templateUrl: './create-branch-paths.component.html'
4240
})
4341
export class CreateBranchPathsComponent {
4442
protected readonly CHOICE_CHOSEN_VALUE: string = CHOICE_CHOSEN_VALUE;

src/assets/wise5/authoringTool/teacher-node-icon/teacher-node-icon.component.ts

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,17 @@ import { MatIconModule } from '@angular/material/icon';
1111
import { MatBadgeModule } from '@angular/material/badge';
1212

1313
@Component({
14-
imports: [
15-
CommonModule,
16-
FlexLayoutModule,
17-
MatBadgeModule,
18-
MatButtonModule,
19-
MatIconModule,
20-
MatTooltipModule,
21-
NodeIconChooserDialogComponent
22-
],
23-
selector: 'teacher-node-icon',
24-
styleUrl: '../../vle/node-icon/node-icon.component.scss',
25-
templateUrl: '../../vle/node-icon/node-icon.component.html'
14+
imports: [
15+
CommonModule,
16+
FlexLayoutModule,
17+
MatBadgeModule,
18+
MatButtonModule,
19+
MatIconModule,
20+
MatTooltipModule
21+
],
22+
selector: 'teacher-node-icon',
23+
styleUrl: '../../vle/node-icon/node-icon.component.scss',
24+
templateUrl: '../../vle/node-icon/node-icon.component.html'
2625
})
2726
export class TeacherNodeIconComponent extends NodeIconComponent {
2827
constructor(

src/assets/wise5/classroomMonitor/classroomMonitorComponents/component-grading.component.ts

Lines changed: 19 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,27 @@ import { PeerChatGradingModule } from '../../components/peerChat/peer-chat-gradi
2525
import { ShowGroupWorkGradingModule } from '../../components/showGroupWork/show-group-work-grading/show-group-work-grading.module';
2626
import { TableGradingModule } from '../../components/table/table-grading/table-grading.module';
2727
import { ShowMyWorkGradingModule } from '../../components/showMyWork/show-my-work-grading/show-my-work-grading.module';
28-
import { MultipleChoiceGradingComponent } from '../../components/multipleChoice/multiple-choice-grading/multiple-choice-grading.component';
29-
import { DialogGuidanceGradingComponent } from '../../components/dialogGuidance/dialog-guidance-grading/dialog-guidance-grading.component';
3028

3129
@Component({
32-
imports: [
33-
AiChatGradingModule,
34-
AnimationGradingModule,
35-
AudioOscillatorGradingModule,
36-
ConceptMapGradingModule,
37-
DialogGuidanceGradingComponent,
38-
DiscussionGradingModule,
39-
DrawGradingModule,
40-
EmbeddedGradingModule,
41-
GraphGradingModule,
42-
LabelGradingModule,
43-
MatchGradingModule,
44-
MultipleChoiceGradingComponent,
45-
OpenResponseGradingModule,
46-
PeerChatGradingModule,
47-
ShowGroupWorkGradingModule,
48-
ShowMyWorkGradingModule,
49-
TableGradingModule
50-
],
51-
selector: 'component-grading-component',
52-
template: '<div #component></div>'
30+
imports: [
31+
AiChatGradingModule,
32+
AnimationGradingModule,
33+
AudioOscillatorGradingModule,
34+
ConceptMapGradingModule,
35+
DiscussionGradingModule,
36+
DrawGradingModule,
37+
EmbeddedGradingModule,
38+
GraphGradingModule,
39+
LabelGradingModule,
40+
MatchGradingModule,
41+
OpenResponseGradingModule,
42+
PeerChatGradingModule,
43+
ShowGroupWorkGradingModule,
44+
ShowMyWorkGradingModule,
45+
TableGradingModule
46+
],
47+
selector: 'component-grading-component',
48+
template: '<div #component></div>'
5349
})
5450
export class ComponentGradingComponent {
5551
@ViewChild('component') private componentElementRef: ElementRef;

src/assets/wise5/components/dialogGuidance/dialog-responses/dialog-responses.component.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,7 @@ import { MatIconModule } from '@angular/material/icon';
1111
import { RubricEventService } from '../../common/cRater/crater-rubric/RubricEventService';
1212

1313
@Component({
14-
imports: [
15-
CommonModule,
16-
CRaterRubricComponent,
17-
DetectedIdeasComponent,
18-
DialogResponseComponent,
19-
MatIconModule
20-
],
14+
imports: [CommonModule, DetectedIdeasComponent, DialogResponseComponent, MatIconModule],
2115
selector: 'dialog-responses',
2216
styleUrl: './dialog-responses.component.scss',
2317
templateUrl: './dialog-responses.component.html'

src/assets/wise5/components/openResponse/open-response-authoring/open-response-authoring.component.html

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,4 @@
11
<div class="openResponse" flex>
2-
<style>
3-
{{nodeContent.style}}
4-
</style>
52
@if (!componentContent.showPreviousWork) {
63
<div>
74
<mat-icon

src/assets/wise5/vle/vle.component.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,10 @@ import { StepToolsComponent } from '../themes/default/themeComponents/stepTools/
2929
import { RunEndedAndLockedMessageComponent } from './run-ended-and-locked-message/run-ended-and-locked-message.component';
3030
import { NodeComponent } from './node/node.component';
3131
import { NavigationComponent } from '../themes/default/navigation/navigation.component';
32-
import { ChooseBranchPathDialogComponent } from '../../../app/preview/modules/choose-branch-path-dialog/choose-branch-path-dialog.component';
3332

3433
@Component({
3534
imports: [
3635
CommonModule,
37-
ChooseBranchPathDialogComponent,
3836
GroupTabsComponent,
3937
MatSidenavModule,
4038
NavigationComponent,

src/messages.xlf

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10279,7 +10279,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
1027910279
</context-group>
1028010280
<context-group purpose="location">
1028110281
<context context-type="sourcefile">src/assets/wise5/vle/vle.component.ts</context>
10282-
<context context-type="linenumber">197</context>
10282+
<context context-type="linenumber">195</context>
1028310283
</context-group>
1028410284
</trans-unit>
1028510285
<trans-unit id="537022937435161177" datatype="html">
@@ -10294,7 +10294,7 @@ Click &quot;Cancel&quot; to keep the invalid JSON open so you can fix it.</sourc
1029410294
</context-group>
1029510295
<context-group purpose="location">
1029610296
<context context-type="sourcefile">src/assets/wise5/vle/vle.component.ts</context>
10297-
<context context-type="linenumber">198</context>
10297+
<context context-type="linenumber">196</context>
1029810298
</context-group>
1029910299
</trans-unit>
1030010300
<trans-unit id="3407061818321766940" datatype="html">
@@ -20251,7 +20251,7 @@ Current Score: <x id="PH_1" equiv-text="currentScore"/></source>
2025120251
<source>If you want to use rich visuals (images, videos, links, bullets, etc.) in your prompt, use an HTML component above this</source>
2025220252
<context-group purpose="location">
2025320253
<context context-type="sourcefile">src/assets/wise5/components/openResponse/open-response-authoring/open-response-authoring.component.html</context>
20254-
<context context-type="linenumber">8,11</context>
20254+
<context context-type="linenumber">5,8</context>
2025520255
</context-group>
2025620256
</trans-unit>
2025720257
<trans-unit id="4633085794688959129" datatype="html">

0 commit comments

Comments
 (0)