Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Containing relevant launch information" should be well-defined #68

Closed
yoavweiss opened this issue Oct 19, 2022 · 5 comments
Closed

"Containing relevant launch information" should be well-defined #68

yoavweiss opened this issue Oct 19, 2022 · 5 comments

Comments

@yoavweiss
Copy link

Instead of that phrase at launching a web app we should define an algorithm that initializes a LaunchParams object, and defines its values.

@alancutter
Copy link
Collaborator

Initialising the LaunchParams object will be up to the different launch triggers e.g. share target or file handler, it's a parameter to this algorithm. "containing relevant launch information" should probably be non-normative text instead.

@yoavweiss
Copy link
Author

I don't think it should be non-normative, but instead we need to define those concepts, if they aren't defined elsewhere.

/cc @mgiuca @dmurph @chasephillips for thoughts

@alancutter
Copy link
Collaborator

I'm not sure of a way to say "containing relevant launch information" in normative text and I don't think it's actually necessary to state. The LaunchParams is just an input parameter to the algorithm and if the caller has a good reason to include irrelevant launch information that's fine.
Do you think it's okay to delete this phrasing and just resolve #67 ?

@yoavweiss
Copy link
Author

Getting LaunchParams as input makes sense. Then it's on the callers you mentioned in #67 (comment) to strictly define the relevant ones.

@alancutter
Copy link
Collaborator

This will be fixed as part of: #67

@alancutter alancutter closed this as not planned Won't fix, can't repro, duplicate, stale Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants