Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent references to the renderUrls parameter in the documentation for SSP K/V call #882

Open
rdgordon-index opened this issue Oct 25, 2023 · 4 comments

Comments

@rdgordon-index
Copy link
Contributor

renderUrls (camel case) is mentioned https://github.com/WICG/turtledove/blob/main/FLEDGE_Key_Value_Server_API.md#examples:

https://www.ssp-kv-server.example/v1/getvalues?renderUrls=url1,url2&adComponentRenderUrls=url3,url4

And that's in fact what we see in the network tab for the SSP K/V call:
image

However, both the explainer and the spec make mention of renderURLs -- where URL is all-uppercase -- which doesn't match Chrome's behaviour.

Can the docs & spec be updated accordingly?

@rdgordon-index
Copy link
Contributor Author

@MattMenke2 -- I saw you recently opened #991 -- would this cover all the instances noted above?

@MattMenke2
Copy link
Contributor

Yes. The issue here is that we started with renderUrl, but Web Javascript standards use renderURL. So currently, we support both, but we want to get everyone over to using renderURL, and then (eventually) remove renderUrl, probably displaying some sort of warning for quite some time until we finally remove it.

@MattMenke2
Copy link
Contributor

Oops, my PR only updates the explainer, not the other files.

@rdgordon-index
Copy link
Contributor Author

#1381 is related as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants