Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to change the append and compress argument of vtk_grid in writeVTK #56

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

chmerdon
Copy link
Member

@chmerdon chmerdon commented Jul 23, 2024

see https://juliavtk.github.io/WriteVTK.jl/dev/grids/syntax/ for the purpose of append and compress and Issue JuliaVTK/WriteVTK.jl#136 where these somehow lead to corrupted files that cannot be opened with some paraview versions on some architectures (I have this case on my machine).

By putting the defaults of append and compress to false this issues can be avoided it seems.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (06a2f11) to head (807f9d4).
Report is 72 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   73.01%   73.77%   +0.76%     
==========================================
  Files          27       32       +5     
  Lines        4239     4881     +642     
==========================================
+ Hits         3095     3601     +506     
- Misses       1144     1280     +136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j-fu j-fu merged commit f84e164 into WIAS-PDELib:master Sep 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants