Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some uniqueNames don't match up with i18n entries #617

Open
Cypheriel opened this issue Aug 26, 2024 · 2 comments
Open

[Bug] Some uniqueNames don't match up with i18n entries #617

Cypheriel opened this issue Aug 26, 2024 · 2 comments
Labels
help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Enhancement Improves existing feature

Comments

@Cypheriel
Copy link

Describe the bug

Item's such as /Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum are missing i18n entries in i18n.json

NodeJS Version

N/A

npm Version

N/A

warframe-items Version

N/A

Access Method

npm Package (Default)

What happened?

When looking at the components of Wyrm Prime, you are given /Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum for its cerebrum. However, when looking that uniqueName up in i18n.json, there are zero matches. It does seem that the Public Export provides the correct value under /Lotus/Language/Menu/CraftingComponent_PrimeWyrmCerebrum: "Wyrm Prime Cerebrum". It's worth mentioning that I gathered this information from an unrelated project, however I hope it provides some insight into the issue.

Side note: It would seem that the names for components in general tend to be... too vague. For example, "Cerebrum" as a component name is close to unusable when it comes to internationalization. In this case, it should be "Wyrm Prime Cerebrum", as it would be in-game.

@Cypheriel Cypheriel added help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Bug labels Aug 26, 2024
@WFCD WFCD deleted a comment Aug 26, 2024
@TobiTenno
Copy link
Member

yeah, the problem is you're comparing a language entry for the interface (/Lotus/Language/Menu/CraftingComponent_PrimeWyrmCerebrum) with a component item (/Lotus/Types/Recipes/Weapons/WeaponParts/PrimeWyrmCerebrum). We have no way to mesh these values.

re: "generic" component names, that's on purpose to allow better image coalescing with common component images so we don't accidentally generate thousands of duplicate images.

There's not really anything for us to do here, as they aren't programmatically related (like one of the names isn't combined in the other) apart from the final part of the component item being appended to /Lotus/Language/Menu/CraftingComponent_, which we can't really confirm is universally true to mesh up.

@TobiTenno TobiTenno closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
@TobiTenno
Copy link
Member

i'll try it out, but definitely reclassing this as an enhancement request

@TobiTenno TobiTenno reopened this Aug 27, 2024
@TobiTenno TobiTenno added Type: Enhancement Improves existing feature and removed Type: Bug labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Scope: Out of Scope Not provided by DE's API Severity4: Inconvenient The defect does not affect functionality or critical data. It is merely an inconvenience. Type: Enhancement Improves existing feature
Projects
None yet
Development

No branches or pull requests

2 participants