Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sarek #248

Closed
pythonlover02 opened this issue Sep 30, 2024 · 15 comments · Fixed by #250
Closed

Add Sarek #248

pythonlover02 opened this issue Sep 30, 2024 · 15 comments · Fixed by #250
Labels
enhancement New feature or request

Comments

@pythonlover02
Copy link

Is your feature request related to a problem? Please describe.
Nop

Describe the solution you'd like
Adding Proton-Sarek or Proton-For-Old-Vulkan Builds: https://github.com/pythonlover02/Proton-Sarek/tree/Stable

Describe alternatives you've considered
Manually downloading the Sarek builds

Additional context
Sarek (Proton-For-Old-Vulkan) is a custom Proton build featuring DXVK 1.10.3 and DXVK 1.10.3 Async, tailored for users with GPUs supporting Vulkan 1.1+ (but not 1.3+) and non-Vulkan setups. It offers patched versions of Proton-GE for improved performance on old hardware, with little enhancements to WineD3D. Originally created for two friends with GT 710 GPUs, the goal is to allow users with older GPUs to run Proton-GE without needing to use older versions.

Im the creator and main maintainer of the repo, i come here because some people would really like those builds to be on ProtonPlus for a more easy access, anything that i need to know, or do i am at the orders. :)

@pythonlover02 pythonlover02 added the enhancement New feature or request label Sep 30, 2024
@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

I am going to be off for 2 months in a few days, but I will try my best to add it before I am going.

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

I've added it, but the current way my application works makes it so I need to choose one element from the list of asset.
Could you tell me what do you plan the asset section to look like continuing forward otherwise if it's not stable I will not be able to add your runner to ProtonPlus.
I am saying that because the first two don't have async, but have testing so if you plan on changing that a lot I would need to make something special just for your runner and I won't have time before I am going.
Screenshot from 2024-10-02 16-10-51
Screenshot from 2024-10-02 16-12-07

@pythonlover02
Copy link
Author

pythonlover02 commented Oct 2, 2024

I've added it, but the current way my application works makes it so I need to choose one element from the list of asset. Could you tell me what do you plan the asset section to look like continuing forward otherwise if it's not stable I will not be able to add your runner to ProtonPlus. I am saying that because the first two don't have async, but have testing so if you plan on changing that a lot I would need to make something special just for your runner and I won't have time before I am going. Screenshot from 2024-10-02 16-10-51 Screenshot from 2024-10-02 16-12-07

Damn, that was really, really fast. As for what builds to display, show only the normal versions. The async versions could have issues with anticheat, so I don’t want them near someone who won’t read the documentation. The same goes for the testing builds, since being testing builds, they could even mess up some game prefixes.
This said, thanks for your work and for accepting mine in your program :), also if you need anything more i am at the orders.

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

Okay so you don't want me to create a second entry for the async version?

Do you plan to keep the assets order like below or will that change?
Screenshot from 2024-10-02 16-12-07

@pythonlover02
Copy link
Author

pythonlover02 commented Oct 2, 2024

Okay so you don't want me to create a second entry for the async version?

If you can it would be awesome, but its not a priority.

Do you plan to keep the assets order like below or will that change? Screenshot from 2024-10-02 16-12-07

About the assets it should always be like that unless i make a testing release. Also i will restructure the first release so all the releases always follow this order: async - stable - testing or if you want an specific one that will make your life easy just say it and i will make it, maybe stable - async - testing?

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

If the only thing that will not always be there is the testing releases, I am fine with whatever order you want as long as async and stable always exists and are in the same position.

@pythonlover02
Copy link
Author

If the only thing that will not always be there is the testing releases, I am fine with whatever order you want as long as async and stable always exists and are in the same position.

oh okey, async - stable - testing it is then.

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

Okay, so I've excluded the 9.13 and 9.13-r1 since they weren't respecting that order and I will be creating a PR soon

@Vysp3r Vysp3r linked a pull request Oct 2, 2024 that will close this issue
@Vysp3r Vysp3r mentioned this issue Oct 2, 2024
@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

Just to make sure we're on the same page and for nothing to break on my end, just make sure you always have async and then stable in the assets in that order.

@pythonlover02
Copy link
Author

Just to make sure we're on the same page and for nothing to break on my end, just make sure you always have async and then stable in the assets in that order.

Yes i understand, also thanks for adding my build, its such an honor :)

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 2, 2024

I made a release with it.
It should be available within 24h.

@Vysp3r
Copy link
Owner

Vysp3r commented Oct 3, 2024

I forgot to add your runner to the list of runner thats in the description of the application, but I'll make an hotfix tomorrow to fix that before I go.

@pythonlover02
Copy link
Author

I forgot to add your runner to the list of runner thats in the description of the application, but I'll make an hotfix tomorrow to fix that before I go.

No problem, sleep well :)

@Arcitec
Copy link
Collaborator

Arcitec commented Oct 4, 2024

Normally, projects only had one asset, so we never had the issue before where we have to find the correct asset in a release.

But to make this more robust, we will be switching to regex to find assets instead of relying on the current positions.

You can subscribe to #261 to keep track of when that issue is closed. Vysp3r will be gone for over a month and after that, regex will be added after the refactoring #246 is complete, so I estimate around 2 months.

Until then, it's important that async is always the first asset and normal is always the second asset, as you confirmed already. :)

@pythonlover02
Copy link
Author

Normally, projects only had one asset, so we never had the issue before where we have to find the correct asset in a release.

But to make this more robust, we will be switching to regex to find assets instead of relying on the current positions.

You can subscribe to #261 to keep track of when that issue is closed. Vysp3r will be gone for over a month and after that, regex will be added after the refactoring #246 is complete, so I estimate around 2 months.

Until then, it's important that async is always the first asset and normal is always the second asset, as you confirmed already. :)

I’ll make sure that async is always the first asset and normal is the second. Also, i will keep an eye on #261 and #246 for updates. Thanks again for the clarity, and good luck with the refactor! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants