Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pyparsing recursion issue #45

Open
Vlek opened this issue Jul 10, 2021 · 4 comments
Open

Fix pyparsing recursion issue #45

Vlek opened this issue Jul 10, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Vlek
Copy link
Owner

Vlek commented Jul 10, 2021

When checking for recursion issues using pyparsing's built-in method, it flags as there being one.

What I found is that this happens whenever we have the dice notation supplied for both one and two operands being available. This likely means that there is a better way to do what we're doing, potentially moving away from the inFixNotation or adding an optional number for the left operand in the 1 operand statement and removing the other.

@Vlek Vlek added the bug Something isn't working label Jul 10, 2021
@Vlek Vlek added this to the 3.0 milestone Jul 10, 2021
@Vlek Vlek self-assigned this Jul 10, 2021
@Vlek
Copy link
Owner Author

Vlek commented Jul 11, 2021

Tests should be generated for this and other pyparsing issues as well!

https://github.com/pyparsing/pyparsing/wiki/Parser-Debugging-and-Diagnostics

@Vlek
Copy link
Owner Author

Vlek commented Jul 11, 2021

Also, we can remove the second unary minus, it's no longer needed with refactor.

@Vlek
Copy link
Owner Author

Vlek commented Jul 15, 2021

This may resolve our ((((((((((1 + 1)))))))))) max recursion depth issue. If it does not, we will have to create a separate issue to address it.

@Vlek
Copy link
Owner Author

Vlek commented Jul 15, 2021

This issue may also come with a parser speed hit which may impact our speed metrics in #41. This issue should be considered related until we know otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant