Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use config file #4

Open
VladimirAlexiev opened this issue Sep 9, 2019 · 2 comments
Open

use config file #4

VladimirAlexiev opened this issue Sep 9, 2019 · 2 comments

Comments

@VladimirAlexiev
Copy link
Owner

@jazzyray:
#3 adds the use of a config file plantuml.cfg. I see the following issues:

  1. It should check for the presence of such file, or should have an option. Should not die if a config file is not present.
  2. hide empty methods etc are necessary for the diagram to look ok. So it's better to leave these in: they could be specified in the config file, but what's the benefit given that they must always be present?
  3. Rather than concating the config file, it should use the -config option as per https://forum.plantuml.net/4266/configuration-file-specification (another option is to use #include inside the file, but I think it's slightly less convenient)
  4. It should document the feature
@jazzyray
Copy link

jazzyray commented Sep 9, 2019

The config file is in the repository. It will be cloned. I see no reason to check for existence. If it has been deleted something has gone wrong, why not die?

Do you want me to delete the config file that is in master, that is not used?
https://github.com/VladimirAlexiev/rdf2rml/blob/master/bin/plantuml.cfg

Will look at points 3 and 4.

@VladimirAlexiev
Copy link
Owner Author

VladimirAlexiev commented Sep 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants