Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please avoid including generated code as part of source #32

Open
jonassmedegaard opened this issue May 19, 2024 · 4 comments
Open

Please avoid including generated code as part of source #32

jonassmedegaard opened this issue May 19, 2024 · 4 comments

Comments

@jonassmedegaard
Copy link

The project contains files that are not "the preferred form of the work for making modifications to it", as the GPL license defines source code to be.

Please consider tracking only source with git, and then maybe when issuing releases not only issue source releases but also use some Github mechanisms (which I am not familiar with, just notice exists) to release generated files.

@VladimirAlexiev
Copy link
Owner

VladimirAlexiev commented Jul 10, 2024

@jonassmedegaard

  • Guess you mean the packed binary rdfpuml.exe? Where should I post it then?
  • Guess you don't mean eg .png? They are generated and used in the documentation

@jonassmedegaard
Copy link
Author

Preferrably both: I would assume that the build routines used to generate documentation can be easily extended to also generate the needed png files.
But if that's problematic, then files that potentially embed differently licensed material is the most important to not include with source.

@VladimirAlexiev
Copy link
Owner

  • rdfpuml.exe is a self-executing zip archive that includes the libraries needed by rdfpuml.pl (in source: since Perl compiles on demand). What's wrong with distributing it?
  • images come from the test/*/*.png, where Makefiles make them from test/*/*.ttl. I rerun them when needed, not each time when the HTML docs are made

when issuing releases not only issue source releases but also use some Github mechanisms (which I am not familiar with, just notice exists) to release generated files.

I'm not familiar with them either. But I'll look into #33 .

@jonassmedegaard
Copy link
Author

What's wrong with distributing it?

There is no single universal "wrong", so it depends on what you want, really. If you don't want to streamline the packaging, to separate source from generated artifacts, then I will stop wasting both of our time, and stop trying to help you get your project into shape for CPAN distribution. Possibly your style of managing your code is still suitable for acceptance with CPAN, I don't really know. I do know that your style of managing code is not acceptable for Debian, but there I can circumvent your bloat and potential licensing problems locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants